From: Ivan Maidanski Date: Sat, 15 Oct 2011 11:27:56 +0000 (+0400) Subject: Put 'FIXME' word where missed X-Git-Tag: libatomic_ops-7_3alpha2~77 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4799b4816845f6d999f2853dc1f0c8a6cd9dcd91;p=libatomic_ops Put 'FIXME' word where missed * src/atomic_ops.h (AO_compiler_barrier): Add FIXME. * src/atomic_ops/sysdeps/gcc/cris.h (header comment): Likewise. * src/atomic_ops/sysdeps/armcc/arm_v6.h: Replace C++ style comment with ANSI C one. --- diff --git a/src/atomic_ops.h b/src/atomic_ops.h index 36376b9..334dba0 100644 --- a/src/atomic_ops.h +++ b/src/atomic_ops.h @@ -183,7 +183,8 @@ /* But the documentation warns about VC++ 2003 and earlier. */ # endif #elif defined(__INTEL_COMPILER) -# define AO_compiler_barrier() __memory_barrier() /* Too strong? IA64-only? */ +# define AO_compiler_barrier() __memory_barrier() + /* FIXME: Too strong? IA64-only? */ #elif defined(_HPUX_SOURCE) # if defined(__ia64) # include diff --git a/src/atomic_ops/sysdeps/armcc/arm_v6.h b/src/atomic_ops/sysdeps/armcc/arm_v6.h index a239587..7b43151 100644 --- a/src/atomic_ops/sysdeps/armcc/arm_v6.h +++ b/src/atomic_ops/sysdeps/armcc/arm_v6.h @@ -229,4 +229,4 @@ AO_compare_double_and_swap_double(volatile AO_double_t *addr, } #define AO_HAVE_compare_double_and_swap_double -#endif // __TARGET_ARCH_ARM +#endif /* __TARGET_ARCH_ARM >= 6 */ diff --git a/src/atomic_ops/sysdeps/gcc/cris.h b/src/atomic_ops/sysdeps/gcc/cris.h index cbca1e7..5b9a6f3 100644 --- a/src/atomic_ops/sysdeps/gcc/cris.h +++ b/src/atomic_ops/sysdeps/gcc/cris.h @@ -21,11 +21,10 @@ * * Most of this code originally comes from Hans-Peter Nilsson. It is included * here with his permission. - * - * This version has not been tested. It was coped here from a GC - * patch so that we wouldn't lose the code in the upgrade to gc7. */ +/* FIXME: seems to be untested. */ + #include "../all_atomic_load_store.h" #include "../ordered.h" /* There are no multiprocessor implementations. */