From: Reuben Thomas <rrt@sc3d.org>
Date: Sat, 27 Jan 2018 13:57:24 +0000 (+0000)
Subject: Remove redundant memset calls zeroing memory
X-Git-Tag: v3.7~39
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4684c424675f20fde770b8ed5cf2f581c48539f2;p=recode

Remove redundant memset calls zeroing memory

Now that ALLOC uses calloc.

Also replace a use of malloc then memset with calloc.
---

diff --git a/src/outer.c b/src/outer.c
index 848db81..3f11ea8 100644
--- a/src/outer.c
+++ b/src/outer.c
@@ -480,7 +480,7 @@ unregister_all_modules (RECODE_OUTER outer)
 RECODE_OUTER
 recode_new_outer (unsigned flags)
 {
-  RECODE_OUTER outer = (RECODE_OUTER) malloc (sizeof (struct recode_outer));
+  RECODE_OUTER outer = (RECODE_OUTER) calloc (1, sizeof (struct recode_outer));
 
   if (!outer)
     {
@@ -490,7 +490,6 @@ recode_new_outer (unsigned flags)
       return NULL;
     }
 
-  memset (outer, 0, sizeof (struct recode_outer));
   outer->auto_abort = (flags & RECODE_AUTO_ABORT_FLAG) != 0;
   outer->use_iconv = (flags & RECODE_NO_ICONV_FLAG) == 0;
 
diff --git a/src/request.c b/src/request.c
index 644e119..cc976a7 100644
--- a/src/request.c
+++ b/src/request.c
@@ -1123,7 +1123,6 @@ recode_new_request (RECODE_OUTER outer)
   if (!ALLOC (request, 1, struct recode_request))
     return NULL;
 
-  memset (request, 0, sizeof (struct recode_request));
   request->outer = outer;
   request->diaeresis_char = '"';
 
diff --git a/src/task.c b/src/task.c
index d705099..57a54a9 100644
--- a/src/task.c
+++ b/src/task.c
@@ -509,7 +509,6 @@ recode_new_task (RECODE_CONST_REQUEST request)
   if (!ALLOC (task, 1, struct recode_task))
     return NULL;
 
-  memset (task, 0, sizeof (struct recode_task));
   task->request = request;
   task->strategy = RECODE_STRATEGY_UNDECIDED;
   task->fail_level = RECODE_NOT_CANONICAL;