From: Douglas Gregor Date: Wed, 12 Oct 2011 18:51:02 +0000 (+0000) Subject: We do parse hexfloats in C++11; make it actually work. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=46717308883538841da7059e72bc898abe0c8724;p=clang We do parse hexfloats in C++11; make it actually work. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@141798 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Lex/Lexer.cpp b/lib/Lex/Lexer.cpp index c7a3df50bc..802024f79b 100644 --- a/lib/Lex/Lexer.cpp +++ b/lib/Lex/Lexer.cpp @@ -1358,8 +1358,7 @@ void Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { } // If we have a hex FP constant, continue. - if ((C == '-' || C == '+') && (PrevCh == 'P' || PrevCh == 'p') && - !Features.CPlusPlus0x) + if ((C == '-' || C == '+') && (PrevCh == 'P' || PrevCh == 'p')) return LexNumericConstant(Result, ConsumeChar(CurPtr, Size, Result)); // Update the location of token as well as BufferPtr. diff --git a/lib/Lex/LiteralSupport.cpp b/lib/Lex/LiteralSupport.cpp index 96550e6492..70183fd1a0 100644 --- a/lib/Lex/LiteralSupport.cpp +++ b/lib/Lex/LiteralSupport.cpp @@ -562,9 +562,6 @@ void NumericLiteralParser::ParseNumberStartingWithZero(SourceLocation TokLoc) { } s = first_non_digit; - // In C++0x, we cannot support hexadecmial floating literals because - // they conflict with user-defined literals, so we warn in previous - // versions of C++ by default. if (!PP.getLangOptions().HexFloats) PP.Diag(TokLoc, diag::ext_hexconstant_invalid); } else if (saw_period) { diff --git a/test/Lexer/hexfloat.cpp b/test/Lexer/hexfloat.cpp index 493b64e627..23daa49ad2 100644 --- a/test/Lexer/hexfloat.cpp +++ b/test/Lexer/hexfloat.cpp @@ -1,9 +1,4 @@ // RUN: %clang_cc1 -fsyntax-only -verify -pedantic %s -// RUN: %clang_cc1 -std=c++0x -fsyntax-only -verify %s -// XFAIL: * +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify -pedantic %s +float f = 0x1p+1; // expected-warning{{hexadecimal floating constants are a C99 feature}} -#ifndef __GXX_EXPERIMENTAL_CXX0X__ -float f = 0x1p+1; // expected-warning {{incompatible with C++0x}} -#else -float f = 0x1p+1; // expected-warning {{invalid suffix}} -#endif