From: R. David Murray <rdmurray@bitdance.com>
Date: Thu, 3 Jun 2010 20:19:25 +0000 (+0000)
Subject: #8889: rewrite transient_internet so we don't use EAI_NODATA on FreeBSD.
X-Git-Tag: v2.7rc1~42
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4653fb556c5dacdbd4d8afadd2f73a6c0b394157;p=python

#8889: rewrite transient_internet so we don't use EAI_NODATA on FreeBSD.

FreeBSD doesn't have socket.EAI_NODATA.  I rewrote the routine because
there's no easy way to conditionally include a context manager in a
with statement.  As a side benefit, instead of a stack of context
managers there's now only one.
---

diff --git a/Lib/test/test_support.py b/Lib/test/test_support.py
index 8add116e23..6e7853b89e 100644
--- a/Lib/test/test_support.py
+++ b/Lib/test/test_support.py
@@ -750,17 +750,32 @@ class TransientResource(object):
                 raise ResourceDenied("an optional resource is not available")
 
 
+_transients = {
+    IOError: (errno.ECONNRESET, errno.ETIMEDOUT),
+    socket.error: (errno.ECONNRESET,),
+    socket.gaierror: [getattr(socket, t)
+                      for t in ('EAI_NODATA', 'EAI_NONAME')
+                      if hasattr(socket, t)],
+    }
 @contextlib.contextmanager
 def transient_internet():
     """Return a context manager that raises ResourceDenied when various issues
-    with the Internet connection manifest themselves as exceptions."""
-    time_out = TransientResource(IOError, errno=errno.ETIMEDOUT)
-    socket_peer_reset = TransientResource(socket.error, errno=errno.ECONNRESET)
-    ioerror_peer_reset = TransientResource(IOError, errno=errno.ECONNRESET)
-    dns_nodata = TransientResource(socket.gaierror, errno=socket.EAI_NODATA)
-    dns_noname = TransientResource(socket.gaierror, errno=socket.EAI_NONAME)
-    with time_out, socket_peer_reset, ioerror_peer_reset, dns_nodata, dns_noname:
+    with the Internet connection manifest themselves as exceptions.
+
+    Errors caught:
+        timeout             IOError                  errno = ETIMEDOUT
+        socket reset        socket.error, IOError    errno = ECONNRESET
+        dns no data         socket.gaierror          errno = EAI_NODATA
+        dns no name         socket.gaierror          errno = EAI_NONAME
+    """
+    try:
         yield
+    except tuple(_transients) as err:
+        for errtype in _transients:
+            if isinstance(err, errtype) and err.errno in _transients[errtype]:
+                raise ResourceDenied("could not establish network "
+                                     "connection ({})".format(err))
+        raise
 
 
 @contextlib.contextmanager
diff --git a/Misc/NEWS b/Misc/NEWS
index 81891c15a1..8d69ebeb32 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -105,7 +105,10 @@ Extension Modules
 Tests
 -----
 
-- Issue #8835: test_support.transient_internet() catchs gaierror(EAI_NONAME)
+- Issue #8889: test_support.transient_internet rewritten so that the new
+  checks also work on FreeBSD, which lacks EAI_NODATA.
+
+- Issue #8835: test_support.transient_internet() catches gaierror(EAI_NONAME)
   and gaierror(EAI_NODATA)
 
 - Issue #7449: Skip test_socketserver if threading support is disabled