From: Robert Haas <rhaas@postgresql.org>
Date: Fri, 27 Aug 2010 21:31:19 +0000 (+0000)
Subject: Insert additional compiler placation into objectaddress.c.
X-Git-Tag: REL9_1_ALPHA1~18
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=462583be1ce7fe8a75abffc41a0db38e03050090;p=postgresql

Insert additional compiler placation into objectaddress.c.

Peter Eisentraut reports that some bits of the "address" variable
in get_object_address() give "may be used uninitialized" warnings;
this likes the only excuse his compiler could have for thinking
that's possible.
---

diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c
index 9eec92f40a..9054d75c9e 100644
--- a/src/backend/catalog/objectaddress.c
+++ b/src/backend/catalog/objectaddress.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/objectaddress.c,v 1.1 2010/08/27 11:47:41 rhaas Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/objectaddress.c,v 1.2 2010/08/27 21:31:19 rhaas Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -215,6 +215,10 @@ get_object_address(ObjectType objtype, List *objname, List *objargs,
 			break;
 		default:
 			elog(ERROR, "unrecognized objtype: %d", (int) objtype);
+			/* placate compiler, in case it things elog might return */
+			address.classId = InvalidOid;
+			address.objectId = InvalidOid;
+			address.objectSubId = 0;
 	}
 
 	/*