From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Thu, 22 Jul 2021 02:14:51 +0000 (-0700)
Subject: gml2gv: [nfc] remove mode argument to openFile
X-Git-Tag: 2.49.0~41^2~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=45c17c68c1921b90480f09a2f05a2f2070723e2b;p=graphviz

gml2gv: [nfc] remove mode argument to openFile

This function is only ever called with mode "w". This is the equivalent of
21a6f2e2f7e8a377977c7bdad1356591a25d516f for gml2gv.
---

diff --git a/cmd/tools/gml2gv.c b/cmd/tools/gml2gv.c
index da3de133d..3ee0c4065 100644
--- a/cmd/tools/gml2gv.c
+++ b/cmd/tools/gml2gv.c
@@ -51,19 +51,14 @@ static FILE *getFile(void)
     return rv;
 }
 
-static FILE *openFile(const char *name, const char *mode)
+static FILE *openFile(const char *name)
 {
     FILE *fp;
-    char *modestr;
 
-    fp = fopen(name, mode);
+    fp = fopen(name, "w");
     if (!fp) {
-        if (*mode == 'r')
-            modestr = "reading";
-        else
-            modestr = "writing";
-        fprintf(stderr, "%s: could not open file %s for %s\n",
-                CmdName, name, modestr);
+        fprintf(stderr, "%s: could not open file %s for writing\n",
+                CmdName, name);
         perror(name);
         exit(1);
     }
@@ -113,7 +108,7 @@ static void initargs(int argc, char **argv)
 	case 'o':
 	    if (outFile != NULL)
 		fclose(outFile);
-	    outFile = openFile(optarg, "w");
+	    outFile = openFile(optarg);
 	    break;
 	case ':':
 	    fprintf(stderr, "%s: option -%c missing argument\n", CmdName, optopt);