From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 28 May 2014 19:41:53 +0000 (-0400)
Subject: Fix bogus %name-prefix option syntax in all our Bison files.
X-Git-Tag: REL9_4_BETA2~128
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=45b7abe59e9485657ac9380f35d2d917dd0da25b;p=postgresql

Fix bogus %name-prefix option syntax in all our Bison files.

%name-prefix doesn't use an "=" sign according to the Bison docs, but it
silently accepted one anyway, until Bison 3.0.  This was originally a
typo of mine in commit 012abebab1bc72043f3f670bf32e91ae4ee04bd2, and we
seem to have slavishly copied the error into all the other grammar files.

Per report from Vik Fearing; analysis by Peter Eisentraut.

Back-patch to all active branches, since somebody might try to build
a back branch with up-to-date tools.
---

diff --git a/contrib/cube/cubeparse.y b/contrib/cube/cubeparse.y
index 0baee8e132..aa6961916e 100644
--- a/contrib/cube/cubeparse.y
+++ b/contrib/cube/cubeparse.y
@@ -39,7 +39,7 @@ static NDBOX * write_point_as_box(char *s, int dim);
 /* BISON Declarations */
 %parse-param {NDBOX **result}
 %expect 0
-%name-prefix="cube_yy"
+%name-prefix "cube_yy"
 
 %token CUBEFLOAT O_PAREN C_PAREN O_BRACKET C_BRACKET COMMA
 %start box
diff --git a/contrib/seg/segparse.y b/contrib/seg/segparse.y
index 3fad9910bd..2311c1e63c 100644
--- a/contrib/seg/segparse.y
+++ b/contrib/seg/segparse.y
@@ -42,7 +42,7 @@ static char strbuf[25] = {
 /* BISON Declarations */
 %parse-param {SEG *result}
 %expect 0
-%name-prefix="seg_yy"
+%name-prefix "seg_yy"
 
 %union {
 	struct BND {
diff --git a/src/backend/bootstrap/bootparse.y b/src/backend/bootstrap/bootparse.y
index 5585e9b6b9..64757a9702 100644
--- a/src/backend/bootstrap/bootparse.y
+++ b/src/backend/bootstrap/bootparse.y
@@ -93,7 +93,7 @@ static int num_columns_read = 0;
 %}
 
 %expect 0
-%name-prefix="boot_yy"
+%name-prefix "boot_yy"
 
 %union
 {
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 7b9895d61e..c00e410377 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -169,7 +169,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
 
 %pure-parser
 %expect 0
-%name-prefix="base_yy"
+%name-prefix "base_yy"
 %locations
 
 %parse-param {core_yyscan_t yyscanner}
diff --git a/src/backend/replication/repl_gram.y b/src/backend/replication/repl_gram.y
index 154aaace9f..f369da3024 100644
--- a/src/backend/replication/repl_gram.y
+++ b/src/backend/replication/repl_gram.y
@@ -40,7 +40,7 @@ Node *replication_parse_result;
 %}
 
 %expect 0
-%name-prefix="replication_yy"
+%name-prefix "replication_yy"
 
 %union {
 		char					*str;
diff --git a/src/interfaces/ecpg/preproc/ecpg.header b/src/interfaces/ecpg/preproc/ecpg.header
index 64e7600a8c..da3e9b2908 100644
--- a/src/interfaces/ecpg/preproc/ecpg.header
+++ b/src/interfaces/ecpg/preproc/ecpg.header
@@ -572,7 +572,7 @@ add_typedef(char *name, char *dimension, char *length, enum ECPGttype type_enum,
 %}
 
 %expect 0
-%name-prefix="base_yy"
+%name-prefix "base_yy"
 %locations
 
 %union {
diff --git a/src/pl/plpgsql/src/pl_gram.y b/src/pl/plpgsql/src/pl_gram.y
index e3a992cf0f..f64d5b8e15 100644
--- a/src/pl/plpgsql/src/pl_gram.y
+++ b/src/pl/plpgsql/src/pl_gram.y
@@ -110,7 +110,7 @@ static	List			*read_raise_options(void);
 %}
 
 %expect 0
-%name-prefix="plpgsql_yy"
+%name-prefix "plpgsql_yy"
 %locations
 
 %union {
diff --git a/src/test/isolation/specparse.y b/src/test/isolation/specparse.y
index 5243f19283..97662f3ee6 100644
--- a/src/test/isolation/specparse.y
+++ b/src/test/isolation/specparse.y
@@ -20,7 +20,7 @@ TestSpec		parseresult;			/* result of parsing is left here */
 %}
 
 %expect 0
-%name-prefix="spec_yy"
+%name-prefix "spec_yy"
 
 %union
 {