From: Martin v. Löwis <martin@v.loewis.de>
Date: Thu, 6 May 2004 01:54:36 +0000 (+0000)
Subject: Swap public and system ID in start_doctype_decl. Fixes #780300.
X-Git-Tag: v2.4a1~443
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=456ab1d2712dc9cebd878966c8fb16af47ea79f0;p=python

Swap public and system ID in start_doctype_decl. Fixes #780300.
---

diff --git a/Doc/whatsnew/whatsnew24.tex b/Doc/whatsnew/whatsnew24.tex
index 8e2b11ec31..ff8a3fa1ce 100644
--- a/Doc/whatsnew/whatsnew24.tex
+++ b/Doc/whatsnew/whatsnew24.tex
@@ -561,6 +561,10 @@ changes to your code:
 \item \function{dircache.listdir()} now passes exceptions to the caller
       instead of returning empty lists.
 
+\item \function{LexicalHandler.startDTD} used to receive public and system ID
+  in the wrong order. This has been corrected; applications relying on the
+  wrong order need to be fixed.
+
 \end{itemize}
 
 
diff --git a/Lib/xml/sax/expatreader.py b/Lib/xml/sax/expatreader.py
index 58ad773581..ab8cbc1244 100644
--- a/Lib/xml/sax/expatreader.py
+++ b/Lib/xml/sax/expatreader.py
@@ -361,7 +361,7 @@ class ExpatParser(xmlreader.IncrementalParser, xmlreader.Locator):
     def end_namespace_decl(self, prefix):
         self._cont_handler.endPrefixMapping(prefix)
 
-    def start_doctype_decl(self, name, pubid, sysid, has_internal_subset):
+    def start_doctype_decl(self, name, sysid, pubid, has_internal_subset):
         self._lex_handler_prop.startDTD(name, pubid, sysid)
 
     def unparsed_entity_decl(self, name, base, sysid, pubid, notation_name):
diff --git a/Misc/NEWS b/Misc/NEWS
index 983c548882..809d2d972c 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -306,6 +306,9 @@ Extension modules
 Library
 -------
 
+- Bug #780300: Swap public and system ID in LexicalHandler.startDTD.
+  Applications relying on the wrong order need to be corrected.
+
 - Bug #926075: Fixed a bug that returns a wrong pattern object
   for a string or unicode object in sre.compile() when a different
   type pattern with the same value exists.