From: Nadeem Vawda <nadeem.vawda@gmail.com>
Date: Mon, 1 Oct 2012 21:02:50 +0000 (+0200)
Subject: Issue #16304: Another performance optimization for BZ2File.
X-Git-Tag: v3.3.1rc1~815^2~58^2~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=452add08a186a09f346a28306c96f4c89bf93c9e;p=python

Issue #16304: Another performance optimization for BZ2File.

Patch by Serhiy Storchaka.
---

diff --git a/Lib/bz2.py b/Lib/bz2.py
index 37918a8b53..87bed214d0 100644
--- a/Lib/bz2.py
+++ b/Lib/bz2.py
@@ -159,21 +159,18 @@ class BZ2File(io.BufferedIOBase):
             raise ValueError("I/O operation on closed file")
 
     def _check_can_read(self):
-        if self.closed:
-            raise ValueError("I/O operation on closed file")
         if self._mode not in (_MODE_READ, _MODE_READ_EOF):
+            self._check_not_closed()
             raise io.UnsupportedOperation("File not open for reading")
 
     def _check_can_write(self):
-        if self.closed:
-            raise ValueError("I/O operation on closed file")
         if self._mode != _MODE_WRITE:
+            self._check_not_closed()
             raise io.UnsupportedOperation("File not open for writing")
 
     def _check_can_seek(self):
-        if self.closed:
-            raise ValueError("I/O operation on closed file")
         if self._mode not in (_MODE_READ, _MODE_READ_EOF):
+            self._check_not_closed()
             raise io.UnsupportedOperation("Seeking is only supported "
                                           "on files open for reading")
         if not self._fp.seekable():