From: Zachary Turner <zturner@google.com>
Date: Fri, 17 Mar 2017 00:15:27 +0000 (+0000)
Subject: [PDB] It is not an error getting the "Invalid" Annotation opcode.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=44d826125473d6fb9e1a7800eb735e9014c2fd86;p=llvm

[PDB] It is not an error getting the "Invalid" Annotation opcode.

The linker can insert invalid opcodes to indicate padding
bytes, and we should not fail in this case.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@298016 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/DebugInfo/CodeView/SymbolDumper.cpp b/lib/DebugInfo/CodeView/SymbolDumper.cpp
index fd54fba13c7..134471e81ca 100644
--- a/lib/DebugInfo/CodeView/SymbolDumper.cpp
+++ b/lib/DebugInfo/CodeView/SymbolDumper.cpp
@@ -468,8 +468,8 @@ Error CVSymbolDumperImpl::visitKnownRecord(CVSymbol &CVR,
   for (auto &Annotation : InlineSite.annotations()) {
     switch (Annotation.OpCode) {
     case BinaryAnnotationsOpCode::Invalid:
-      return llvm::make_error<CodeViewError>(
-          "Invalid binary annotation opcode!");
+      W.printString("(Annotation Padding)");
+      break;
     case BinaryAnnotationsOpCode::CodeOffset:
     case BinaryAnnotationsOpCode::ChangeCodeOffset:
     case BinaryAnnotationsOpCode::ChangeCodeLength: