From: nhmall <nhmall@nethack.org>
Date: Fri, 13 May 2022 00:10:27 +0000 (-0400)
Subject: yet more version buf
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=44c225a11ebd6a6126d206045f2bf2db5b6f2383;p=nethack

yet more version buf
---

diff --git a/win/Qt/qt_bind.cpp b/win/Qt/qt_bind.cpp
index 2ddace254..c27a6b643 100644
--- a/win/Qt/qt_bind.cpp
+++ b/win/Qt/qt_bind.cpp
@@ -88,7 +88,7 @@ NetHackQtBind::NetHackQtBind(int& argc, char** argv) :
     QCoreApplication::setApplicationName("NetHack-Qt"); // Qt NetHack
     {
         char cvers[BUFSZ];
-        QString qvers = QString(::version_string(cvers));
+        QString qvers = QString(::version_string(cvers, sizeof cvers));
         QCoreApplication::setApplicationVersion(qvers);
     }
 #ifdef MACOS
diff --git a/win/Qt/qt_main.cpp b/win/Qt/qt_main.cpp
index bac9b465b..bfacd2635 100644
--- a/win/Qt/qt_main.cpp
+++ b/win/Qt/qt_main.cpp
@@ -459,7 +459,7 @@ aboutMsg()
     char *p, vbuf[BUFSZ];
     /* nethack's getversionstring() includes a final period
        but we're using it mid-sentence so strip period off */
-    if ((p = strrchr(::getversionstring(vbuf), '.')) != 0 && *(p + 1) == '\0')
+    if ((p = strrchr(::getversionstring(vbuf, sizeof vbuf), '.')) != 0 && *(p + 1) == '\0')
         *p = '\0';
     /* it's also long; break it into two pieces */
     (void) strsubst(vbuf, " - ", "\n- ");
diff --git a/win/Qt/qt_plsel.cpp b/win/Qt/qt_plsel.cpp
index 92060e8fc..4c04c355c 100644
--- a/win/Qt/qt_plsel.cpp
+++ b/win/Qt/qt_plsel.cpp
@@ -280,7 +280,7 @@ NetHackQtPlayerSelector::NetHackQtPlayerSelector(
     QVBoxLayout* vbab UNUSED = new QVBoxLayout(alignbox);
     char versionbuf[QBUFSZ];
     QLabel *logo = new QLabel(QString(nh_attribution).arg(
-                                           version_string(versionbuf)), this);
+                        version_string(versionbuf, sizeof versionbuf)), this);
 
     l->addWidget( namebox, 0,0,1,3 );
     role = new NhPSListView(this);
diff --git a/win/Qt/qt_svsel.cpp b/win/Qt/qt_svsel.cpp
index 9fcc3854d..1ff94835a 100644
--- a/win/Qt/qt_svsel.cpp
+++ b/win/Qt/qt_svsel.cpp
@@ -66,7 +66,7 @@ NetHackQtSavedGameSelector::NetHackQtSavedGameSelector(const char** saved) :
     QHBoxLayout* hb;
 
     char cvers[BUFSZ];
-    QString qvers = QString("NetHack ") + QString(version_string(cvers));
+    QString qvers = QString("NetHack ") + QString(version_string(cvers, sizeof cvers));
     QLabel *vers = new QLabel(qvers, this);
     vers->setAlignment(Qt::AlignCenter);
     vbl->addWidget(vers);