From: Matthew Fernandez Date: Sat, 26 Feb 2022 19:01:57 +0000 (-0800) Subject: expr: [nfc] remove unnecessary parens and dereference of 'setf' X-Git-Tag: 4.0.0~204^2~5 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=44a3d32b7eda8812b249c61ed54aa37731b672e2;p=graphviz expr: [nfc] remove unnecessary parens and dereference of 'setf' The C compiler knows how to dereference and call through a function pointer without needing this manual instruction. --- diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c index ac27d3820..366153f41 100644 --- a/lib/expr/exeval.c +++ b/lib/expr/exeval.c @@ -1209,7 +1209,9 @@ eval(Expr_t* ex, Exnode_t* expr, void* env) locv = getdyn(ex, x->data.variable.dyna, env, &assoc); x->data.variable.dyna->data.variable.dyna->data.constant.value = locv; } - if ((*ex->disc->setf)(ex, x, x->data.variable.symbol, x->data.variable.reference, env, (int)i.integer, v, ex->disc) < 0) + if (ex->disc->setf(ex, x, x->data.variable.symbol, + x->data.variable.reference, env, (int)i.integer, v, + ex->disc) < 0) exerror("%s: cannot set value", x->data.variable.symbol->name); } if (expr->subop == PRE)