From: Tim Chase <tim@chase2k.com>
Date: Sat, 18 Jan 2014 16:46:43 +0000 (-0600)
Subject: Allow chown/chgrp when no ACL SAs exist.
X-Git-Tag: zfs-0.6.3~110
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=4461aa6118fa55dc83f5d75c6d428767c3634fba;p=zfs

Allow chown/chgrp when no ACL SAs exist.

From the comment in the commit:

Some ZFS implementations (ZEVO) create neither a ZNODE_ACL nor a DACL_ACES
SA in which case ENOENT is returned from zfs_acl_node_read() when the
SA can't be located.  Allow chown/chgrp to succeed in these cases rather
than returning an error that makes no sense in the context of the caller.

Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue zfs-osx/zfs#86
Closes #1911
Closes #2029
---

diff --git a/module/zfs/zfs_acl.c b/module/zfs/zfs_acl.c
index c5f76036f..89b624528 100644
--- a/module/zfs/zfs_acl.c
+++ b/module/zfs/zfs_acl.c
@@ -1166,6 +1166,17 @@ zfs_acl_chown_setattr(znode_t *zp)
 		zp->z_mode = zfs_mode_compute(zp->z_mode, aclp,
 		    &zp->z_pflags, zp->z_uid, zp->z_gid);
 
+	/*
+	 * Some ZFS implementations (ZEVO) create neither a ZNODE_ACL
+	 * nor a DACL_ACES SA in which case ENOENT is returned from
+	 * zfs_acl_node_read() when the SA can't be located.
+	 * Allow chown/chgrp to succeed in these cases rather than
+	 * returning an error that makes no sense in the context of
+	 * the caller.
+	 */
+	if (error == ENOENT)
+		return (0);
+
 	return (error);
 }