From: Tom Lane Date: Fri, 18 Jan 2019 00:31:03 +0000 (-0500) Subject: Avoid assuming that we know the spelling of getopt_long's error messages. X-Git-Tag: REL_11_2~69 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=43404015955804dd6ff10563f4f78f5f352dbe25;p=postgresql Avoid assuming that we know the spelling of getopt_long's error messages. I've had enough of "fixing" this test case. Whatever value it has is limited to verifying that pgbench fails for an unrecognized switch, and we don't need to assume anything about what getopt_long prints in order to do that. Discussion: https://postgr.es/m/9427.1547701450@sss.pgh.pa.us --- diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl index e82d3cb242..e87c028659 100644 --- a/src/bin/pgbench/t/002_pgbench_no_server.pl +++ b/src/bin/pgbench/t/002_pgbench_no_server.pl @@ -62,7 +62,7 @@ my @options = ( [ 'bad option', '-h home -p 5432 -U calvin -d --bad-option', - [ qr{(unrecognized|illegal) option}, qr{--help.*more information} ] + [qr{--help.*more information}] ], [ 'no file',