From: Damiano Galassi Date: Tue, 19 Dec 2017 13:20:45 +0000 (+0100) Subject: MacGui: improve VoiceOver navigation. X-Git-Tag: 1.1.0~178 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=42932cb0ddf4e243a00421940644ee304bfa5719;p=handbrake MacGui: improve VoiceOver navigation. --- diff --git a/macosx/English.lproj/HBFiltersViewController.xib b/macosx/English.lproj/HBFiltersViewController.xib index ac4f4a94f..c9be54e57 100644 --- a/macosx/English.lproj/HBFiltersViewController.xib +++ b/macosx/English.lproj/HBFiltersViewController.xib @@ -1,9 +1,9 @@ - + - + @@ -267,7 +267,6 @@ Bob attempts to better preserve motion for a slight penalty to perceived resolut - NSNegateBoolean @@ -399,7 +398,7 @@ Default: mode=3:spatial-metric=2:motion-thresh=1:spatial-thresh=1:filter-mode=2: - + @@ -411,7 +410,7 @@ Default: mode=3:spatial-metric=2:motion-thresh=1:spatial-thresh=1:filter-mode=2: - + Sharpening enhances the appearance of detail, especially edges. Overly strong Sharpen settings may damage picture quality by creating ringing artifacts and enhancing noise, which can reduce compression efficiency. @@ -464,8 +463,8 @@ Lapsharp sharpens using convolution kernels approximating Laplacian edge filters + - NSNegateBoolean @@ -509,7 +508,7 @@ Lapsharp sharpens using convolution kernels approximating Laplacian edge filters - + @@ -521,7 +520,7 @@ Lapsharp sharpens using convolution kernels approximating Laplacian edge filters - + Denoise reduces or removes the appearance of noise and grain. This can improve compression efficiency and create higher quality video at smaller file sizes. Overly strong Denoise settings may damage picture quality by discarding detail. @@ -574,8 +573,8 @@ HQDN3D is an adaptive low-pass filter, faster than NLMeans but less effective at + - NSNegateBoolean @@ -613,6 +612,7 @@ Sprite is useful for 1-/4-/8-/16-bit 2-dimensional games. Sprite is not designed + @@ -708,6 +708,7 @@ Lapsharp's Sprite tune is useful for 1-/4-/8-/16-bit 2-dimensional games. Sprite + diff --git a/macosx/English.lproj/HBPictureViewController.xib b/macosx/English.lproj/HBPictureViewController.xib index 6741fb67e..6ffe35020 100644 --- a/macosx/English.lproj/HBPictureViewController.xib +++ b/macosx/English.lproj/HBPictureViewController.xib @@ -20,264 +20,300 @@ - - + + - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - - - - - - Cropping mode. + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + + + + + + Cropping mode. Automatic detects and removes black borders from the video. Custom allows for manual settings. - - - - - - - - - - + + + + - - + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + + + + - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - - - - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - 0 - - - - - - - - - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - 0 - - - - - - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - - - - - - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - 0 - - - - - - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - 0 - - - - - + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + 0 + + + + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + + + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + 0 + + + + + + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + 0 + + + + + + + + + + + + + + + + + + + + + + NSIsNotNil + + + + + NSNegateBoolean + + + + + 0 + + + + + + + + - + Display width. This is the number of pixels wide your video will appear to be at its native resolution, and is the result of scaling the storage dimensions by the pixel aspect. @@ -299,7 +335,7 @@ Custom allows for manual settings. - + Display height. This is the number of pixels tall your video will appear to be at its native resolution, and is the result of scaling the storage dimensions by the pixel aspect. @@ -320,7 +356,7 @@ Custom allows for manual settings. - + Pixel Aspect Ratio defines the shape of the storage pixels, or how to scale anamorphic video to create the correct display aspect and dimensions. Non-anamorphic video (1:1 PAR) is not scaled during playback. @@ -343,7 +379,7 @@ Custom allows for manual settings. - + @@ -355,11 +391,12 @@ Custom allows for manual settings. - + - + + @@ -372,7 +409,7 @@ Custom allows for manual settings. - + Ensure storage dimensions are multiples of this value. Higher values are only necessary for compatibility with certain legacy devices. Set to 2 unless you have a specific compatibility concern. @@ -398,7 +435,7 @@ Custom allows for manual settings. - + Video storage width. This is the number of pixels wide to be encoded. Storage width may differ from display width depending on anamorphic settings. @@ -424,7 +461,7 @@ Custom allows for manual settings. - + @@ -436,34 +473,35 @@ Custom allows for manual settings. - + - + + - + - + - + - + - + Anamorphic allows arbitrary storage dimensions while preserving the original aspect during playback. @@ -497,7 +535,7 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec - + @@ -509,7 +547,7 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec - + @@ -518,10 +556,11 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec + - + @@ -533,7 +572,7 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec - + Video storage height. This is the number of pixels tall to be encoded. Storage height may differ from display height depending on anamorphic settings. @@ -559,7 +598,7 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec - + Pixel Aspect Ratio defines the shape of the storage pixels, or how to scale anamorphic video to create the correct display aspect and dimensions. Non-anamorphic video (1:1 PAR) is not scaled during playback. @@ -580,11 +619,12 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec - + - + + @@ -595,33 +635,8 @@ Custom allows manually setting all parameters. Useful for correcting an incorrec - - - - - - - - - - - - - - NSIsNotNil - - - - - NSNegateBoolean - - - - - - + + + diff --git a/macosx/English.lproj/HBPreviewViewController.xib b/macosx/English.lproj/HBPreviewViewController.xib index 45c5f2a3d..bfc74d7d7 100644 --- a/macosx/English.lproj/HBPreviewViewController.xib +++ b/macosx/English.lproj/HBPreviewViewController.xib @@ -33,6 +33,7 @@ + @@ -47,6 +48,7 @@ + diff --git a/macosx/English.lproj/HBSummaryViewController.xib b/macosx/English.lproj/HBSummaryViewController.xib index e7df77063..d91afc97e 100644 --- a/macosx/English.lproj/HBSummaryViewController.xib +++ b/macosx/English.lproj/HBSummaryViewController.xib @@ -2,6 +2,7 @@ + @@ -51,7 +52,7 @@ - + @@ -59,7 +60,7 @@ - + @@ -67,7 +68,7 @@ - + @@ -85,6 +86,7 @@ + @@ -93,11 +95,13 @@ + + - + @@ -112,6 +116,7 @@ + diff --git a/macosx/English.lproj/MainWindow.xib b/macosx/English.lproj/MainWindow.xib index bd180c649..f61d0d77f 100644 --- a/macosx/English.lproj/MainWindow.xib +++ b/macosx/English.lproj/MainWindow.xib @@ -111,6 +111,7 @@ + @@ -178,6 +179,7 @@ + @@ -209,7 +211,7 @@ - + @@ -336,6 +338,9 @@ + + + @@ -434,7 +439,6 @@ - @@ -492,6 +496,7 @@ Blu-ray and DVD sources often have multiple titles, the longest of which is typi + @@ -568,7 +573,7 @@ Blu-ray and DVD sources often have multiple titles, the longest of which is typi - + + @@ -726,7 +732,7 @@ Blu-ray and DVD sources often have multiple titles, the longest of which is typi - + @@ -803,7 +809,7 @@ Blu-ray and DVD sources often have multiple titles, the longest of which is typi - + diff --git a/macosx/HBController.m b/macosx/HBController.m index 187bf7929..95cda984f 100644 --- a/macosx/HBController.m +++ b/macosx/HBController.m @@ -203,6 +203,7 @@ [self enableUI:NO]; // Bottom + fRipIndicator.hidden = YES; [self updateProgress]; // Register HBController's Window as a receiver for files/folders drag & drop operations diff --git a/macosx/HBPreviewView.m b/macosx/HBPreviewView.m index 8bd40ea87..4e293750f 100644 --- a/macosx/HBPreviewView.m +++ b/macosx/HBPreviewView.m @@ -278,4 +278,25 @@ return resultSize; } +#pragma MARK: - Accessibility + +- (BOOL)isAccessibilityElement +{ + return YES; +} + +- (NSAccessibilityRole)accessibilityRole +{ + return NSAccessibilityImageRole; +} + +- (NSString *)accessibilityLabel +{ + if (self.image) + { + return [NSString stringWithFormat:NSLocalizedString(@"Previw Image Size: %zu x %zu, Scale: %.0f%%", nil), CGImageGetWidth(self.image), CGImageGetHeight(self.image), self.scale * 100]; + } + return NSLocalizedString(@"No image", nil); +} + @end