From: Saleem Abdulrasool Date: Mon, 30 May 2016 18:26:06 +0000 (+0000) Subject: CodeGen: address post-commit review comments X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=425451c09203faa370fc97765ec51f69c6c5579b;p=clang CodeGen: address post-commit review comments David Majnemer pointed out that isOSBinFormatMachO is more compact. NFC. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@271221 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index cd278e65c1..eb3adcb6e7 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -3147,7 +3147,7 @@ CodeGenModule::GetAddrOfConstantCFString(const StringLiteral *Literal) { // FIXME: We set the section explicitly to avoid a bug in ld64 224.1. // Without it LLVM can merge the string with a non unnamed_addr one during // LTO. Doing that changes the section it ends in, which surprises ld64. - if (getTarget().getTriple().getObjectFormat() == llvm::Triple::MachO) + if (getTarget().getTriple().isOSBinFormatMachO()) GV->setSection(isUTF16 ? "__TEXT,__ustring" : "__TEXT,__cstring,cstring_literals");