From: Jeff King Date: Fri, 11 Jan 2019 22:15:54 +0000 (-0500) Subject: config: make a copy of $GIT_CONFIG string X-Git-Tag: v2.21.0-rc0~69^2~3 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=423ff9bef003b41f81949e7a88d7278b48334ed4;p=git config: make a copy of $GIT_CONFIG string cmd_config() points our source filename pointer at the return value of getenv(), but that value may be invalidated by further calls to environment functions. Let's copy it to make sure it remains valid. We don't need to bother freeing it, as it remains part of the whole-process global state until we exit. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/builtin/config.c b/builtin/config.c index 97b58c4aea..752d0c65d7 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -595,7 +595,7 @@ int cmd_config(int argc, const char **argv, const char *prefix) int nongit = !startup_info->have_repository; char *value; - given_config_source.file = getenv(CONFIG_ENVIRONMENT); + given_config_source.file = xstrdup_or_null(getenv(CONFIG_ENVIRONMENT)); argc = parse_options(argc, argv, prefix, builtin_config_options, builtin_config_usage,