From: Peter Eisentraut <peter_e@gmx.net>
Date: Tue, 30 May 2017 18:57:01 +0000 (-0400)
Subject: Remove replication slot name check from ReplicationSlotAcquire()
X-Git-Tag: REL_10_BETA2~248
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=420a0392ef8fdac3eb6f0a616c136215f7454674;p=postgresql

Remove replication slot name check from ReplicationSlotAcquire()

When trying to access a replication slot that is supposed to already
exist, we don't need to check the naming rules again.  If the slot
does not exist, we will then get a "does not exist" error message, which
is generally more useful from the perspective of an end user.
---

diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index 5386e86aa6..c0f7fbb2b2 100644
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -331,8 +331,6 @@ ReplicationSlotAcquire(const char *name)
 
 	Assert(MyReplicationSlot == NULL);
 
-	ReplicationSlotValidateName(name, ERROR);
-
 	/* Search for the named slot and mark it active if we find it. */
 	LWLockAcquire(ReplicationSlotControlLock, LW_SHARED);
 	for (i = 0; i < max_replication_slots; i++)