From: Pieter Lexis <pieterlexis@users.noreply.github.com>
Date: Fri, 15 Jul 2016 09:47:54 +0000 (+0200)
Subject: Merge pull request #4178 from pieterlexis/qtype-to-dnssec-trace
X-Git-Tag: auth-4.0.1~38
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=41f6e66b8a15cf60f539f3bcbf8c4cdce6a87f7d;p=pdns

Merge pull request #4178 from pieterlexis/qtype-to-dnssec-trace

Add QType to log output for DNSSEC trace
---

41f6e66b8a15cf60f539f3bcbf8c4cdce6a87f7d
diff --cc pdns/pdns_recursor.cc
index f054a54d1,3b0bd7fd5..4b2672bbd
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@@ -889,10 -888,10 +889,10 @@@ void startDoResolve(void *p
        pw.getHeader()->rcode=res;
  
        // Does the validation mode or query demand validation?
 -      if(g_dnssecmode == DNSSECMode::ValidateAll || g_dnssecmode==DNSSECMode::ValidateForLog || (dc->d_mdp.d_header.ad && g_dnssecmode==DNSSECMode::Process)) {
 +      if(!shouldNotValidate && (g_dnssecmode == DNSSECMode::ValidateAll || g_dnssecmode==DNSSECMode::ValidateForLog || ((dc->d_mdp.d_header.ad || DNSSECOK) && g_dnssecmode==DNSSECMode::Process))) {
          try {
            if(sr.doLog()) {
-             L<<Logger::Warning<<"Starting validation of answer to "<<dc->d_mdp.d_qname<<" for "<<dc->d_remote.toStringWithPort()<<endl;
+             L<<Logger::Warning<<"Starting validation of answer to "<<dc->d_mdp.d_qname<<"|"<<QType(dc->d_mdp.d_qtype).getName()<<" for "<<dc->d_remote.toStringWithPort()<<endl;
            }
            
            auto state=validateRecords(ret);
@@@ -918,9 -917,9 +918,9 @@@
              }
              
              // Does the query or validation mode sending out a SERVFAIL on validation errors?
 -            if(!pw.getHeader()->cd && (g_dnssecmode == DNSSECMode::ValidateAll || dc->d_mdp.d_header.ad)) {
 +            if(!pw.getHeader()->cd && (g_dnssecmode == DNSSECMode::ValidateAll || dc->d_mdp.d_header.ad || DNSSECOK)) {
                if(sr.doLog()) {
-                 L<<Logger::Warning<<"Sending out SERVFAIL for "<<dc->d_mdp.d_qname<<" because recursor or query demands it for Bogus results"<<endl;
+                 L<<Logger::Warning<<"Sending out SERVFAIL for "<<dc->d_mdp.d_qname<<"|"<<QType(dc->d_mdp.d_qtype).getName()<<" because recursor or query demands it for Bogus results"<<endl;
                }
                
                pw.getHeader()->rcode=RCode::ServFail;