From: Michael Paquier <michael@paquier.xyz>
Date: Wed, 27 Feb 2019 05:14:06 +0000 (+0900)
Subject: Fix memory leak when inserting tuple at relation creation for CTAS
X-Git-Tag: REL_12_BETA1~664
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=414a9d3cf34c7aff1c63533df4c40ebb63bd0840;p=postgresql

Fix memory leak when inserting tuple at relation creation for CTAS

The leak has been introduced by 763f2ed which has addressed the problem
for transient tables, and forgot CREATE TABLE AS which shares a similar
logic when receiving a new tuple to store into the newly-created
relation.

Author: Jeff Janes
Discussion: https://postgr.es/m/CAMkU=1xZXtz3mziPEPD2Fubbas4G2RWkZm5HHABtfKVcbu1=Sg@mail.gmail.com
---

diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c
index 2bc8f928ea..6517ecb738 100644
--- a/src/backend/commands/createas.c
+++ b/src/backend/commands/createas.c
@@ -587,6 +587,9 @@ intorel_receive(TupleTableSlot *slot, DestReceiver *self)
 
 	/* We know this is a newly created relation, so there are no indexes */
 
+	/* Free the copied tuple. */
+	heap_freetuple(tuple);
+
 	return true;
 }