From: Shlomi Fish <shlomif@shlomifish.org>
Date: Mon, 27 Feb 2023 13:51:30 +0000 (+0200)
Subject: ascertain rinutils presence
X-Git-Tag: fortune-mod-3.18.0~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=41454be56d93b153fdbb9749973755b628263020;p=fortune-mod

ascertain rinutils presence

https://github.com/shlomif/fortune-mod/issues/76
---

diff --git a/fortune-mod/.tidyallrc b/fortune-mod/.tidyallrc
index f81db2b..33d2ec6 100644
--- a/fortune-mod/.tidyallrc
+++ b/fortune-mod/.tidyallrc
@@ -3,7 +3,7 @@ select = **/*.{c,h}
 
 [PerlTidy]
 argv = -ci=4 -bl -cti=0 --character-encoding=none
-ignore = rinutils/run-tests.pl **/t/valgrind*.t
+ignore = rinutils/run-tests.pl rinutils/t/lib/Rinutils/InlineWrap.pm **/t/valgrind*.t
 select = **/*.{pl,pm,t}
 
 [PerlCritic]
diff --git a/fortune-mod/cmake/rinutils_bootstrap.cmake b/fortune-mod/cmake/rinutils_bootstrap.cmake
index 3879bce..6dc92da 100644
--- a/fortune-mod/cmake/rinutils_bootstrap.cmake
+++ b/fortune-mod/cmake/rinutils_bootstrap.cmake
@@ -5,21 +5,22 @@ MACRO(RINUTILS_SET_UP_FLAGS)
     SET (rinutils_inc_dir "${rinutils_dir_absolute}/rinutils/include")
     SET (rinutils_git_tag "0.6.0")
 
+    IF (NOT EXISTS "${rinutils_inc_dir}")
+        EXECUTE_PROCESS(
+            COMMAND "git" "clone" "-b" "${rinutils_git_tag}" "https://github.com/shlomif/rinutils.git" "${rinutils_dir}"
+            WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
+        )
+#       ELSE ()
+#           EXECUTE_PROCESS(
+#               COMMAND "git" "submodule" "update" "--init"
+#               WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
+#           )
+    ENDIF ()
+
     find_package(Rinutils QUIET)
     IF ("${Rinutils_FOUND}")
         INCLUDE_DIRECTORIES(AFTER ${RINUTILS_INCLUDE_DIR} ${RINUTILS_INCLUDE_DIRS})
     ELSE ()
-        IF (NOT EXISTS "${rinutils_inc_dir}")
-            EXECUTE_PROCESS(
-                COMMAND "git" "clone" "-b" "${rinutils_git_tag}" "https://github.com/shlomif/rinutils.git" "${rinutils_dir}"
-                WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
-            )
-        ELSE ()
-            EXECUTE_PROCESS(
-                COMMAND "git" "submodule" "update" "--init"
-                WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
-            )
-        ENDIF ()
         IF (NOT EXISTS "${rinutils_inc_dir}")
             MESSAGE(FATAL_ERROR "Could not find rinutils anywhere - it should have been bundled in the releases' source tarball.\nYou can try installing it from a source release or from its repository: https://github.com/shlomif/rinutils\n\nAlso see: https://github.com/shlomif/fortune-mod/issues/44")
         ENDIF ()
diff --git a/fortune-mod/tests/t/check-rinutils.t b/fortune-mod/tests/t/check-rinutils.t
index 0e6c355..4aebd28 100644
--- a/fortune-mod/tests/t/check-rinutils.t
+++ b/fortune-mod/tests/t/check-rinutils.t
@@ -21,17 +21,18 @@ sub check_file
 sub mytest
 {
     my $dir = "$ENV{SRC_DIR}/rinutils";
-    if ( -e $dir )
+    if ( not -e $dir )
     {
-        # body...
-        foreach my $fn ("rinutils/include/rinutils/portable_time.h")
+        fail("-e $dir failed.");
+        return;
+    }
+    foreach my $fn ("rinutils/include/rinutils/portable_time.h")
+    {
+        my $err = check_file("${dir}/${fn}");
+        if ( $err ne '' )
         {
-            my $err = check_file("${dir}/${fn}");
-            if ( $err ne '' )
-            {
-                fail("$fn failed - $err.");
-                return;
-            }
+            fail("$fn failed - $err.");
+            return;
         }
     }
     pass("All are ok.");