From: Ruediger Pluem <rpluem@apache.org>
Date: Wed, 28 Nov 2007 20:52:37 +0000 (+0000)
Subject: * No need for an else block here because we do a return above.
X-Git-Tag: 2.3.0~1215
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=41240cbb062df55bc40e54ce628c5269d4f002fe;p=apache

* No need for an else block here because we do a return above.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@599141 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c
index 8941903111..792ad0a189 100644
--- a/modules/ldap/util_ldap.c
+++ b/modules/ldap/util_ldap.c
@@ -1115,18 +1115,17 @@ static int uldap_cache_check_subgroups(request_rec *r, util_ldap_connection_t *l
             ldc->reason = "check_subgroups failed to find the cache entry to add sub-group list to.";
             return LDAP_COMPARE_FALSE;
         }
+        /*
+         * overwrite SGL if it was previously updated between the last
+         * two times we looked at the cache
+         */
+        compare_nodep->sgl_processed = 1;
+        if (tmp_local_sgl) {
+            compare_nodep->subgroupList = util_ald_sgl_dup(curl->compare_cache, tmp_local_sgl);
+        }
         else {
-             /* overwrite SGL if it was previously updated between the last
-             ** two times we looked at the cache
-             */
-             compare_nodep->sgl_processed = 1;
-             if (tmp_local_sgl) {
-                 compare_nodep->subgroupList = util_ald_sgl_dup(curl->compare_cache, tmp_local_sgl);
-             }
-             else {
-                 /* We didn't find a single subgroup, next time save us from looking */
-                 compare_nodep->subgroupList = NULL;
-             }
+            /* We didn't find a single subgroup, next time save us from looking */
+            compare_nodep->subgroupList = NULL;
         }
         LDAP_CACHE_UNLOCK();
     }