From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 25 Mar 2005 18:04:34 +0000 (+0000)
Subject: Fix two bugs in change_owner_recurse_to_sequences: it was grabbing an
X-Git-Tag: REL8_1_0BETA1~1114
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=410fede0dd8e2effd05aa97baba9fe0fbb23b915;p=postgresql

Fix two bugs in change_owner_recurse_to_sequences: it was grabbing an
overly strong lock on pg_depend, and it wasn't closing the rel when done.
The latter bug was masked by the ResourceOwner code, which is something
that should be changed.
---

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 7c19bcd336..b441b09b0b 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.150 2005/03/24 00:03:22 neilc Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.151 2005/03/25 18:04:34 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5374,7 +5374,7 @@ change_owner_recurse_to_sequences(Oid relationOid, int32 newOwnerSysId)
 	 * SERIAL sequences are those having an internal dependency on one
 	 * of the table's columns (we don't care *which* column, exactly).
 	 */
-	depRel = heap_openr(DependRelationName, RowExclusiveLock);
+	depRel = heap_openr(DependRelationName, AccessShareLock);
 
 	ScanKeyInit(&key[0],
 			Anum_pg_depend_refclassid,
@@ -5420,6 +5420,8 @@ change_owner_recurse_to_sequences(Oid relationOid, int32 newOwnerSysId)
 	}
 
 	systable_endscan(scan);
+
+	relation_close(depRel, AccessShareLock);
 }
 
 /*