From: Denys Vlasenko Date: Fri, 22 Feb 2013 12:23:38 +0000 (+0100) Subject: Use tcp->qual_flg instead of qual_flags[] in verbose() and abbrev() X-Git-Tag: v4.8~128 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=40d63b9a92e049986fce1fb91cca10fdd3d3a64a;p=strace Use tcp->qual_flg instead of qual_flags[] in verbose() and abbrev() We have hundreds of uses of these macros. Result is more efficient and 1.1 kbyte shorter code: text data bss dec hex filename 245579 700 12928 259207 3f487 strace.t5/strace 244471 700 12928 258099 3f033 strace.t6/strace Signed-off-by: Denys Vlasenko --- diff --git a/defs.h b/defs.h index 35620792..39d8b90e 100644 --- a/defs.h +++ b/defs.h @@ -476,8 +476,8 @@ typedef uint8_t qualbits_t; #define entering(tcp) (!((tcp)->flags & TCB_INSYSCALL)) #define exiting(tcp) ((tcp)->flags & TCB_INSYSCALL) #define syserror(tcp) ((tcp)->u_error != 0) -#define verbose(tcp) (qual_flags[(tcp)->scno] & QUAL_VERBOSE) -#define abbrev(tcp) (qual_flags[(tcp)->scno] & QUAL_ABBREV) +#define verbose(tcp) ((tcp)->qual_flg & QUAL_VERBOSE) +#define abbrev(tcp) ((tcp)->qual_flg & QUAL_ABBREV) #define filtered(tcp) ((tcp)->flags & TCB_FILTERED) struct xlat {