From: bert hubert <bert.hubert@netherlabs.nl>
Date: Fri, 11 Apr 2014 07:19:37 +0000 (+0200)
Subject: add little comment to guard against overly simple fix for slow qsize-q metric
X-Git-Tag: rec-3.6.0-rc1~70
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=40c3b29681c839d11f3fd1f6a375868357800306;p=pdns

add little comment to guard against overly simple fix for slow qsize-q metric
---

diff --git a/pdns/common_startup.cc b/pdns/common_startup.cc
index aadc6d568..ffa1cce6b 100644
--- a/pdns/common_startup.cc
+++ b/pdns/common_startup.cc
@@ -268,10 +268,10 @@ void *qthread(void *number)
       numreceived++;
 
     if(number==0) { // only run on main thread
-      if(!((maintcount++)%250)) { // maintenance tasks
+      if(!((maintcount++)%250)) { // maintenance tasks - this can conceivably run infrequently
         S.set("latency",(int)avg_latency);
         int qcount, acount;
-        distributor->getQueueSizes(qcount, acount);
+        distributor->getQueueSizes(qcount, acount);  // this does locking and other things, so don't get smart
         S.set("qsize-q",qcount);
       }
     }