From: Daniel Dunbar Date: Tue, 3 Feb 2009 00:07:12 +0000 (+0000) Subject: Memoize CGFunctionInfo construction. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=40a6be686e5d5bb4198f1affda574e8a4b3a7710;p=clang Memoize CGFunctionInfo construction. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@63576 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGCall.cpp b/lib/CodeGen/CGCall.cpp index 898c780aae..30257d2699 100644 --- a/lib/CodeGen/CGCall.cpp +++ b/lib/CodeGen/CGCall.cpp @@ -86,7 +86,18 @@ const CGFunctionInfo &CodeGenTypes::getFunctionInfo(QualType ResTy, const CGFunctionInfo &CodeGenTypes::getFunctionInfo(QualType ResTy, const llvm::SmallVector &ArgTys) { - return *new CGFunctionInfo(ResTy, ArgTys); + // Lookup or create unique function info. + llvm::FoldingSetNodeID ID; + CGFunctionInfo::Profile(ID, ResTy, ArgTys.begin(), ArgTys.end()); + + void *InsertPos = 0; + CGFunctionInfo *FI = FunctionInfos.FindNodeOrInsertPos(ID, InsertPos); + if (FI) + return *FI; + + FI = new CGFunctionInfo(ResTy, ArgTys); + FunctionInfos.InsertNode(FI, InsertPos); + return *FI; } /***/ diff --git a/lib/CodeGen/CGCall.h b/lib/CodeGen/CGCall.h index aaab36ca83..611304900f 100644 --- a/lib/CodeGen/CGCall.h +++ b/lib/CodeGen/CGCall.h @@ -15,6 +15,7 @@ #ifndef CLANG_CODEGEN_CGCALL_H #define CLANG_CODEGEN_CGCALL_H +#include #include "clang/AST/Type.h" #include "CGValue.h" @@ -49,7 +50,7 @@ namespace CodeGen { /// CGFunctionInfo - Class to encapsulate the information about a /// function definition. - class CGFunctionInfo { + class CGFunctionInfo : public llvm::FoldingSetNode { llvm::SmallVector ArgTypes; public: @@ -62,6 +63,19 @@ namespace CodeGen { arg_iterator arg_end() const; QualType getReturnType() const { return ArgTypes[0]; } + + void Profile(llvm::FoldingSetNodeID &ID) { + Profile(ID, getReturnType(), arg_begin(), arg_end()); + } + template + static void Profile(llvm::FoldingSetNodeID &ID, + QualType ResTy, + Iterator begin, + Iterator end) { + ResTy.Profile(ID); + for (; begin != end; ++begin) + begin->Profile(ID); + } }; } // end namespace CodeGen } // end namespace clang diff --git a/lib/CodeGen/CodeGenTypes.h b/lib/CodeGen/CodeGenTypes.h index d41c23d374..3070c85260 100644 --- a/lib/CodeGen/CodeGenTypes.h +++ b/lib/CodeGen/CodeGenTypes.h @@ -100,6 +100,9 @@ class CodeGenTypes { /// field no. This info is populated by record organizer. llvm::DenseMap FieldInfo; + /// FunctionInfos - Hold memoized CGFunctionInfo results. + llvm::FoldingSet FunctionInfos; + public: class BitFieldInfo { public: