From: Daniel Jasper Date: Fri, 21 Nov 2014 12:36:25 +0000 (+0000) Subject: clang-format: Handle comments in short case labels. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=407d05f300996ee45b51817143e4e7649d829736;p=clang clang-format: Handle comments in short case labels. With AllowShortCaseLabelsOnASingleLine set to true: This gets now left unchanged: case 1: // comment return; Whereas before it was changed into: case 1: // comment return; This fixes llvm.org/PR21630. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@222529 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Format/Format.cpp b/lib/Format/Format.cpp index 729ca97aab..b96c17abbc 100644 --- a/lib/Format/Format.cpp +++ b/lib/Format/Format.cpp @@ -750,7 +750,7 @@ private: if (Line->First->isOneOf(tok::kw_case, tok::kw_default, tok::r_brace)) break; if (Line->First->isOneOf(tok::kw_if, tok::kw_for, tok::kw_switch, - tok::kw_while)) + tok::kw_while, tok::comment)) return 0; Length += I[1 + NumStmts]->Last->TotalLength + 1; // 1 for the space. } diff --git a/unittests/Format/FormatTest.cpp b/unittests/Format/FormatTest.cpp index a6bbe16d86..c58ac0a8f9 100644 --- a/unittests/Format/FormatTest.cpp +++ b/unittests/Format/FormatTest.cpp @@ -745,6 +745,11 @@ TEST_F(FormatTest, ShortCaseLabels) { "case 3:\n" "case 4:\n" "case 5: return;\n" + "case 6: // comment\n" + " return;\n" + "case 7:\n" + " // comment\n" + " return;\n" "default: y = 1; break;\n" "}", Style);