From: Ilia Alshanetsky <iliaa@php.net>
Date: Sun, 29 Aug 2004 17:16:21 +0000 (+0000)
Subject: MFH: Fixed leak when serializing protected & private properties.
X-Git-Tag: php-5.0.2RC1~67
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3f5e121f2bf51cd7835ddb3e10e8388b6b76402b;p=php

MFH: Fixed leak when serializing protected & private properties.
---

diff --git a/ext/standard/var.c b/ext/standard/var.c
index f69606b6f3..f84cd83589 100644
--- a/ext/standard/var.c
+++ b/ext/standard/var.c
@@ -595,6 +595,7 @@ static void php_var_serialize_class(smart_str *buf, zval **struc, zval *retval_p
 									Z_STRVAL_PP(name), Z_STRLEN_PP(name) + 1, ce->type & ZEND_INTERNAL_CLASS);
 						if (zend_hash_find(Z_OBJPROP_PP(struc), priv_name, prop_name_length, (void *) &d) == SUCCESS) {
 							php_var_serialize_string(buf, priv_name, prop_name_length-1);
+							efree(priv_name);
 							php_var_serialize_intern(buf, d, var_hash TSRMLS_CC);
 							break;
 						}
@@ -602,12 +603,16 @@ static void php_var_serialize_class(smart_str *buf, zval **struc, zval *retval_p
 									Z_STRVAL_PP(name), Z_STRLEN_PP(name) + 1, ce->type & ZEND_INTERNAL_CLASS);
 						if (zend_hash_find(Z_OBJPROP_PP(struc), prot_name, prop_name_length, (void *) &d) == SUCCESS) {
 							php_var_serialize_string(buf, prot_name, prop_name_length - 1);
+							efree(prot_name);
 							php_var_serialize_intern(buf, d, var_hash TSRMLS_CC);
 							break;
 						}
 						php_error_docref(NULL TSRMLS_CC, E_NOTICE, "\"%s\" returned as member variable from __sleep() but does not exist", Z_STRVAL_PP(name));
 						php_var_serialize_string(buf, Z_STRVAL_PP(name), Z_STRLEN_PP(name));
 						php_var_serialize_intern(buf, &nvalp, var_hash TSRMLS_CC);
+						
+						efree(prot_name);
+						efree(priv_name);
 					} while (0);
 				} else {
 					php_var_serialize_string(buf, Z_STRVAL_PP(name), Z_STRLEN_PP(name));