From: Steve Lhomme <slhomme@matroska.org>
Date: Sun, 13 Mar 2022 08:52:00 +0000 (+0100)
Subject: KaxSemantic.cpp: make some elements mandatory
X-Git-Tag: release-1.7.0~34
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3f1a5b96ec29f7d14f6b24354db396861e62253d;p=libmatroska

KaxSemantic.cpp: make some elements mandatory

* CodecDelay: nothing to add/remove to track timestamps
* PixelCropXXX: no cropping by default
* CueCodecState
* Tag\Targets\TargetTypeValue: **tag is not usable without this value**

See https://github.com/ietf-wg-cellar/matroska-specification/commit/f81cb9d339574ce2b00faa288cd466908e31b797
---

diff --git a/src/KaxSemantic.cpp b/src/KaxSemantic.cpp
index e9c73d1..1f57a5c 100644
--- a/src/KaxSemantic.cpp
+++ b/src/KaxSemantic.cpp
@@ -245,7 +245,7 @@ DEFINE_SEMANTIC_ITEM(false, false, KaxCodecInfoURL) // not supported
 DEFINE_SEMANTIC_ITEM(false, false, KaxCodecDownloadURL) // not supported
 DEFINE_SEMANTIC_ITEM(true, true, KaxCodecDecodeAll) // not supported
 DEFINE_SEMANTIC_ITEM(false, false, KaxTrackOverlay)
-DEFINE_SEMANTIC_ITEM(false, true, KaxCodecDelay)
+DEFINE_SEMANTIC_ITEM(true, true, KaxCodecDelay)
 DEFINE_SEMANTIC_ITEM(true, true, KaxSeekPreRoll)
 DEFINE_SEMANTIC_ITEM(false, false, KaxTrackTranslate)
 DEFINE_SEMANTIC_ITEM(false, true, KaxTrackVideo)
@@ -326,10 +326,10 @@ DEFINE_SEMANTIC_ITEM(false, true, KaxVideoAlphaMode)
 DEFINE_SEMANTIC_ITEM(false, true, KaxOldStereoMode) // not supported
 DEFINE_SEMANTIC_ITEM(true, true, KaxVideoPixelWidth)
 DEFINE_SEMANTIC_ITEM(true, true, KaxVideoPixelHeight)
-DEFINE_SEMANTIC_ITEM(false, true, KaxVideoPixelCropBottom)
-DEFINE_SEMANTIC_ITEM(false, true, KaxVideoPixelCropTop)
-DEFINE_SEMANTIC_ITEM(false, true, KaxVideoPixelCropLeft)
-DEFINE_SEMANTIC_ITEM(false, true, KaxVideoPixelCropRight)
+DEFINE_SEMANTIC_ITEM(true, true, KaxVideoPixelCropBottom)
+DEFINE_SEMANTIC_ITEM(true, true, KaxVideoPixelCropTop)
+DEFINE_SEMANTIC_ITEM(true, true, KaxVideoPixelCropLeft)
+DEFINE_SEMANTIC_ITEM(true, true, KaxVideoPixelCropRight)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoDisplayWidth)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoDisplayHeight)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoDisplayUnit)
@@ -363,7 +363,7 @@ DEFINE_MKX_FLOAT(KaxVideoFrameRate, 0x2383E3, 3, KaxTrackVideo, "VideoFrameRate"
 
 DEFINE_START_SEMANTIC(KaxVideoColour)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoColourMatrix)
-DEFINE_SEMANTIC_ITEM(false, true, KaxVideoBitsPerChannel)
+DEFINE_SEMANTIC_ITEM(true, true, KaxVideoBitsPerChannel)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoChromaSubsampHorz)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoChromaSubsampVert)
 DEFINE_SEMANTIC_ITEM(false, true, KaxVideoCbSubsampHorz)
@@ -555,7 +555,7 @@ DEFINE_SEMANTIC_ITEM(true, true, KaxCueClusterPosition)
 DEFINE_SEMANTIC_ITEM(false, true, KaxCueRelativePosition)
 DEFINE_SEMANTIC_ITEM(false, true, KaxCueDuration)
 DEFINE_SEMANTIC_ITEM(false, true, KaxCueBlockNumber)
-DEFINE_SEMANTIC_ITEM(false, true, KaxCueCodecState)
+DEFINE_SEMANTIC_ITEM(true, true, KaxCueCodecState)
 DEFINE_SEMANTIC_ITEM(false, false, KaxCueReference)
 DEFINE_END_SEMANTIC(KaxCueTrackPositions)
 
@@ -707,7 +707,7 @@ DEFINE_END_SEMANTIC(KaxTag)
 DEFINE_MKX_MASTER(KaxTag, 0x7373, 2, KaxTags, "Tag")
 
 DEFINE_START_SEMANTIC(KaxTagTargets)
-DEFINE_SEMANTIC_ITEM(false, true, KaxTagTargetTypeValue)
+DEFINE_SEMANTIC_ITEM(true, true, KaxTagTargetTypeValue)
 DEFINE_SEMANTIC_ITEM(false, true, KaxTagTargetType)
 DEFINE_SEMANTIC_ITEM(false, false, KaxTagTrackUID)
 DEFINE_SEMANTIC_ITEM(false, false, KaxTagEditionUID)