From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 29 Jan 2006 17:40:00 +0000 (+0000)
Subject: Fix Assert that's no longer correct now that RowCompareExpr is indexable.
X-Git-Tag: REL8_2_BETA1~1532
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3edec383e1ad8c07dc3ecb9b98e8fb6197e9359e;p=postgresql

Fix Assert that's no longer correct now that RowCompareExpr is indexable.
---

diff --git a/src/backend/optimizer/path/indxpath.c b/src/backend/optimizer/path/indxpath.c
index 4eea16a018..dc93aa6787 100644
--- a/src/backend/optimizer/path/indxpath.c
+++ b/src/backend/optimizer/path/indxpath.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.199 2006/01/29 17:27:42 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.200 2006/01/29 17:40:00 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1611,11 +1611,6 @@ identify_ignorable_ordering_cols(PlannerInfo *root,
 			bool		varonleft;
 			bool		ispc;
 
-			/*
-			 * We know this clause passed match_clause_to_indexcol as a
-			 * toplevel clause; so it's not a ScalarArrayOp.
-			 */
-
 			/* First check for boolean-index cases. */
 			if (IsBooleanOpclass(opclass))
 			{
@@ -1632,8 +1627,9 @@ identify_ignorable_ordering_cols(PlannerInfo *root,
 				}
 			}
 
-			/* Else clause must be a binary opclause. */
-			Assert(IsA(clause, OpExpr));
+			/* Otherwise, ignore if not a binary opclause */
+			if (!is_opclause(clause) || list_length(clause->args) != 2)
+				continue;
 
 			/* Determine left/right sides and check the operator */
 			clause_op = clause->opno;