From: Magnus Hagander <magnus@hagander.net>
Date: Tue, 27 Dec 2016 09:37:11 +0000 (+0100)
Subject: Don't rename .partial files in pg_receivexlog if an error occured
X-Git-Tag: REL_10_BETA1~1185
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3ea56fffd66fe2c5857f36359ae16d4cabcdeef6;p=postgresql

Don't rename .partial files in pg_receivexlog if an error occured

In 56c7d8d the behavior to keep .partial segments around
(considered corrupt) in case an connection failure occurs was
accidentally removed. This would lead to an incomplete segment
being considered complete.

Author: Michael Paquier
---

diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index 4382e5d76a..568ff176ef 100644
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -679,7 +679,7 @@ ReceiveXlogStream(PGconn *conn, StreamCtl *stream)
 	}
 
 error:
-	if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NORMAL) != 0)
+	if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NO_RENAME) != 0)
 		fprintf(stderr, _("%s: could not close file \"%s\": %s\n"),
 		  progname, current_walfile_name, stream->walmethod->getlasterror());
 	walfile = NULL;