From: Chandler Carruth <chandlerc@gmail.com>
Date: Wed, 6 Jul 2011 22:21:45 +0000 (+0000)
Subject: Based on comments from Chris, switch to using CFG::getNumBlockIDs()
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3ea4c49709c5bba5f8b16c6ceb725d9b9a1c48c6;p=clang

Based on comments from Chris, switch to using CFG::getNumBlockIDs()
rather than a computed std::distance(). At some point I had convinced
myself that these two were different; but as far as I can tell on
re-exampination they aren't, and the number of block IDs is actually
just a count of the blocks in the CFG.

While this removes the primary motivation for guarding all of this with
CollectStats, I have a patch coming up that will almost certainly make
it important again.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@134552 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/AnalysisBasedWarnings.cpp b/lib/Sema/AnalysisBasedWarnings.cpp
index 8a4634df2f..089fe7bf3c 100644
--- a/lib/Sema/AnalysisBasedWarnings.cpp
+++ b/lib/Sema/AnalysisBasedWarnings.cpp
@@ -741,10 +741,9 @@ AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
     if (CFG *cfg = AC.getCFG()) {
       // If we successfully built a CFG for this context, record some more
       // detail information about it.
-      unsigned NumBlocks = std::distance(cfg->begin(), cfg->end());
-      NumCFGBlocks += NumBlocks;
+      NumCFGBlocks += cfg->getNumBlockIDs();
       MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
-                                         NumBlocks);
+                                         cfg->getNumBlockIDs());
     } else {
       ++NumFunctionsWithBadCFGs;
     }