From: Richard Trieu <rtrieu@google.com>
Date: Wed, 14 Jun 2017 03:17:26 +0000 (+0000)
Subject: [ODRHash] Hash Template and TemplateExpansion in TemplateArgument.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3e9def378979d880f3efab6c7b3e815e00fa6d11;p=clang

[ODRHash] Hash Template and TemplateExpansion in TemplateArgument.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@305361 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/ODRHash.cpp b/lib/AST/ODRHash.cpp
index 83355270c5..a1c2fbb0c4 100644
--- a/lib/AST/ODRHash.cpp
+++ b/lib/AST/ODRHash.cpp
@@ -150,13 +150,16 @@ void ODRHash::AddTemplateArgument(TemplateArgument TA) {
     case TemplateArgument::Declaration:
     case TemplateArgument::NullPtr:
     case TemplateArgument::Integral:
+      break;
     case TemplateArgument::Template:
     case TemplateArgument::TemplateExpansion:
+      AddTemplateName(TA.getAsTemplateOrTemplatePattern());
       break;
     case TemplateArgument::Expression:
       AddStmt(TA.getAsExpr());
       break;
     case TemplateArgument::Pack:
+      llvm_unreachable("Pack");
       break;
   }
 }
diff --git a/test/Modules/odr_hash.cpp b/test/Modules/odr_hash.cpp
index 36f2e4bea0..51bd626972 100644
--- a/test/Modules/odr_hash.cpp
+++ b/test/Modules/odr_hash.cpp
@@ -1051,6 +1051,24 @@ S3 s3;
 // expected-note@first.h:* {{but in 'FirstModule' found type alias 'T' with different underlying type 'U3<2>'}}
 #endif
 
+#if defined(FIRST)
+template<class> struct T4a {};
+template <template <class> class T> struct U4 {};
+struct S4 {
+  U4<T4a> x;
+};
+#elif defined(SECOND)
+template<class> struct T4b {};
+template <template <class> class T> struct U4 {};
+struct S4 {
+  U4<T4b> x;
+};
+#else
+S4 s4;
+// expected-error@first.h:* {{'TemplateArgument::S4::x' from module 'FirstModule' is not present in definition of 'TemplateArgument::S4' in module 'SecondModule'}}
+// expected-note@second.h:* {{declaration of 'x' does not match}}
+#endif
+
 }
 
 // Interesting cases that should not cause errors.  struct S should not error