From: Kalle Sommer Nielsen Date: Wed, 3 Aug 2016 02:24:17 +0000 (+0200) Subject: Minor touches to the exif build script on Windows; ADD_EXTENSION_DEP() will already... X-Git-Tag: php-7.2.0alpha1~1558^2~71 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3e921aa9dfa2813b5445caacf2bdbdbf8fdd6b2e;p=php Minor touches to the exif build script on Windows; ADD_EXTENSION_DEP() will already ERROR() out, so the WARNING() statement would never be returned anyway. There are probably other similar cases around ext/, however the main reason for fixing this was for the typo (libxml > mbstring). --- diff --git a/ext/exif/config.w32 b/ext/exif/config.w32 index 595e71bda0..ad000c4251 100644 --- a/ext/exif/config.w32 +++ b/ext/exif/config.w32 @@ -1,14 +1,14 @@ // $Id$ // vim:ft=javascript -ARG_ENABLE("exif", "exif", "no"); +ARG_ENABLE('exif', 'Exchangeable image information (EXIF) Support', 'no'); -if (PHP_EXIF == "yes") { - if (ADD_EXTENSION_DEP('exif', 'mbstring')) { - EXTENSION("exif", "exif.c", null, "/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1"); - AC_DEFINE('HAVE_EXIF', 1, 'Have exif'); - } else { - WARNING("exif support can't be enabled, libxml is not enabled") - PHP_EXIF = "no" +if(PHP_EXIF != 'no') +{ + if(ADD_EXTENSION_DEP('exif', 'mbstring')) + { + AC_DEFINE('HAVE_EXIF', 1, 'Have EXIF Support'); + + EXTENSION('exif', 'exif.c', null, '/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1'); } -} +} \ No newline at end of file