From: Ted Kremenek <kremenek@apple.com>
Date: Sat, 10 Nov 2012 04:03:41 +0000 (+0000)
Subject: Revert "Disable -Wimplicit-fallthrough when not using C++.", pending further discussi... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3e7735183b00798efccdee82b9b64b00ef3cd684;p=clang

Revert "Disable -Wimplicit-fallthrough when not using C++.", pending further discussion on cfe-dev.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@167662 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/AnalysisBasedWarnings.cpp b/lib/Sema/AnalysisBasedWarnings.cpp
index 5c21ea4867..a20817f965 100644
--- a/lib/Sema/AnalysisBasedWarnings.cpp
+++ b/lib/Sema/AnalysisBasedWarnings.cpp
@@ -818,19 +818,6 @@ namespace {
 
 static void DiagnoseSwitchLabelsFallthrough(Sema &S, AnalysisDeclContext &AC,
                                             bool PerFunction) {
-  // Only perform this analysis when using C++.  There is no good workflow
-  // for this warning when using straight C.  There is no good way to silence
-  // the warning (no attribute is available) unless we are using C++11's support
-  // for generalized attributes.  Once could use pragmas to silence the warning,
-  // but as a general solution that is gross and not in the spirit of this
-  // warning.
-  //
-  // NOTE: this argument also applies to C++ code not using C++11, as the
-  // generalized attributes are not available in earlier C++ dialects.
-  // This will require some discussion.
-  if (!AC.getASTContext().getLangOpts().CPlusPlus)
-    return;
-
   FallthroughMapper FM(S);
   FM.TraverseStmt(AC.getBody());