From: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Mon, 25 Jun 2012 22:18:45 +0000 (+0100)
Subject: Issue #15179: Closed socket on connection failure. Thanks to Kazutaka Morita for... 
X-Git-Tag: v3.3.0b1~5^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3e6d71d3360f2b8dd0232b492d0a63cc6b5419d3;p=python

Issue #15179: Closed socket on connection failure. Thanks to Kazutaka Morita for the patch.
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 22f8c3446c..d4df5c6d61 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -761,7 +761,11 @@ class SysLogHandler(logging.Handler):
         except socket.error:
             self.socket.close()
             self.socket = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
-            self.socket.connect(address)
+            try:
+                self.socket.connect(address)
+            except socket.error:
+                self.socket.close()
+                raise
 
     def encodePriority(self, facility, priority):
         """