From: Reuben Thomas Date: Wed, 11 Sep 2019 18:46:53 +0000 (+0100) Subject: Fix a couple of potential buffer overflows X-Git-Tag: v3.7.6~5 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3e566ca4b17814de8bc100e3edadbed6e539874f;p=recode Fix a couple of potential buffer overflows --- diff --git a/src/java.c b/src/java.c index 05367f1..4bb8bc9 100644 --- a/src/java.c +++ b/src/java.c @@ -88,7 +88,7 @@ transform_utf16_java (RECODE_SUBTASK subtask) put_byte (value, subtask); else { - char buffer[7]; + char buffer[11]; char *cursor; sprintf (buffer, "\\u%04x", value); diff --git a/src/testdump.c b/src/testdump.c index ff2ee9d..bd45837 100644 --- a/src/testdump.c +++ b/src/testdump.c @@ -254,7 +254,7 @@ produce_count (RECODE_SUBTASK subtask) delayed--; } - sprintf (buffer, "%*u %.4X", (int)count_width, (*cursor)->count, character); + snprintf (buffer, sizeof(buffer), "%*u %.4X", (int)count_width, (*cursor)->count, character); put_string (buffer, subtask); if (mnemonic) {