From: George Wilson Date: Sun, 5 Jul 2015 19:00:34 +0000 (+0200) Subject: Illumos 4966 - zpool list iterator does not update output X-Git-Tag: zfs-0.6.5~77 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3e43edd2c5b40d49bae9881566570a5fb7c2c181;p=zfs Illumos 4966 - zpool list iterator does not update output 4966 zpool list iterator does not update output Reviewed by: Matthew Ahrens Reviewed by: Christopher Siden Reviewed by: Dan McDonald Approved by: Garrett D'Amore References: https://github.com/illumos/illumos-gate/commit/cd67d23 https://www.illumos.org/issues/4966 Ported-by: kernelOfTruth kerneloftruth@gmail.com Signed-off-by: Brian Behlendorf Closes #3566 --- diff --git a/cmd/zpool/zpool_main.c b/cmd/zpool/zpool_main.c index fd1e8284a..e6517574d 100644 --- a/cmd/zpool/zpool_main.c +++ b/cmd/zpool/zpool_main.c @@ -3285,17 +3285,10 @@ zpool_do_list(int argc, char **argv) if (zprop_get_list(g_zfs, props, &cb.cb_proplist, ZFS_TYPE_POOL) != 0) usage(B_FALSE); - if ((list = pool_list_get(argc, argv, &cb.cb_proplist, &ret)) == NULL) - return (1); - - if (argc == 0 && !cb.cb_scripted && pool_list_count(list) == 0) { - (void) printf(gettext("no pools available\n")); - zprop_free_list(cb.cb_proplist); - return (0); - } - for (;;) { - pool_list_update(list); + if ((list = pool_list_get(argc, argv, &cb.cb_proplist, + &ret)) == NULL) + return (1); if (pool_list_count(list) == 0) break; @@ -3315,9 +3308,16 @@ zpool_do_list(int argc, char **argv) if (count != 0 && --count == 0) break; + pool_list_free(list); (void) sleep(interval); } + if (argc == 0 && !cb.cb_scripted && pool_list_count(list) == 0) { + (void) printf(gettext("no pools available\n")); + ret = 0; + } + + pool_list_free(list); zprop_free_list(cb.cb_proplist); return (ret); }