From: Magnus Jacobsson <magnus.jacobsson@berotec.se>
Date: Fri, 2 Oct 2020 13:12:07 +0000 (+0200)
Subject: Show usage and exit non-zero for unsupported option in gvpack
X-Git-Tag: 2.46.0~20^2^2~47^2~30
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3db54708257aafa08445edf3168f858d564b955a;p=graphviz

Show usage and exit non-zero for unsupported option in gvpack

Towards https://gitlab.com/graphviz/graphviz/-/issues/1843.
---

diff --git a/cmd/tools/gvpack.c b/cmd/tools/gvpack.c
index 598d838bf..b2de4bdd7 100644
--- a/cmd/tools/gvpack.c
+++ b/cmd/tools/gvpack.c
@@ -245,9 +245,11 @@ static void init(int argc, char *argv[], pack_info* pinfo)
 	case '?':
 	    if (optopt == '?')
 		usage(0);
-	    else
+	    else {
 		fprintf(stderr,
-			"gvpack: option -%c unrecognized - ignored\n", optopt);
+			"gvpack: option -%c unrecognized\n", optopt);
+		usage(1);
+	    }
 	    break;
 	}
     }