From: Rosen Penev <rosenp@gmail.com>
Date: Tue, 4 Oct 2022 01:36:02 +0000 (-0700)
Subject: use push_back
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3d7b06b43d86b86e8d2311873ce1ea3b6dbbc027;p=libmatroska

use push_back

This is a vector. No need for iterators.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---

diff --git a/src/KaxBlock.cpp b/src/KaxBlock.cpp
index 90fb4f3..041ba73 100644
--- a/src/KaxBlock.cpp
+++ b/src/KaxBlock.cpp
@@ -76,7 +76,6 @@ KaxInternalBlock::~KaxInternalBlock()
 
 KaxInternalBlock::KaxInternalBlock(const KaxInternalBlock & ElementToClone)
   :EbmlBinary(ElementToClone)
-  ,myBuffers(ElementToClone.myBuffers.size())
   ,Timecode(ElementToClone.Timecode)
   ,LocalTimecode(ElementToClone.LocalTimecode)
   ,bLocalTimecodeUsed(ElementToClone.bLocalTimecodeUsed)
@@ -84,11 +83,9 @@ KaxInternalBlock::KaxInternalBlock(const KaxInternalBlock & ElementToClone)
   ,ParentCluster(ElementToClone.ParentCluster) ///< \todo not exactly
 {
   // add a clone of the list
-  auto myItr = myBuffers.begin();
-  for (const auto& buffer : ElementToClone.myBuffers) {
-    *myItr = buffer->Clone();
-    ++myItr;
-  }
+  myBuffers.reserve(ElementToClone.myBuffers.size());
+  for (const auto& buffer : ElementToClone.myBuffers)
+    myBuffers.push_back(buffer->Clone());
 }