From: Jeff King <peff@peff.net>
Date: Sat, 28 Sep 2013 08:31:00 +0000 (-0400)
Subject: http_get_file: style fixes
X-Git-Tag: v1.8.4.3~4^2~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3d1fb769b26dbf278a0ef0cf7427aac86a161bb0;p=git

http_get_file: style fixes

Besides being ugly, the extra parentheses are idiomatic for
suppressing compiler warnings when we are assigning within a
conditional. We aren't doing that here, and they just
confuse the reader.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---

diff --git a/http.c b/http.c
index 2d086aedfa..9b1015881a 100644
--- a/http.c
+++ b/http.c
@@ -941,7 +941,7 @@ static int http_get_file(const char *url, const char *filename, int options)
 
 	strbuf_addf(&tmpfile, "%s.temp", filename);
 	result = fopen(tmpfile.buf, "a");
-	if (! result) {
+	if (!result) {
 		error("Unable to open local file %s", tmpfile.buf);
 		ret = HTTP_ERROR;
 		goto cleanup;
@@ -950,7 +950,7 @@ static int http_get_file(const char *url, const char *filename, int options)
 	ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options);
 	fclose(result);
 
-	if ((ret == HTTP_OK) && move_temp_to_file(tmpfile.buf, filename))
+	if (ret == HTTP_OK && move_temp_to_file(tmpfile.buf, filename))
 		ret = HTTP_ERROR;
 cleanup:
 	strbuf_release(&tmpfile);