From: Alexandre Vassalotti <alexandre@peadrop.com>
Date: Sat, 27 Dec 2008 09:30:39 +0000 (+0000)
Subject: Fix issue #4374: Pickle tests fail w/o _pickle extension.
X-Git-Tag: v3.1a1~663
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3cfcab95924b089d4ba3844db05fa2cb913da0ba;p=python

Fix issue #4374: Pickle tests fail w/o _pickle extension.

Add an initialization check to mimic the interface of _pickle.
---

diff --git a/Lib/pickle.py b/Lib/pickle.py
index 37c3d5262f..201dc9914b 100644
--- a/Lib/pickle.py
+++ b/Lib/pickle.py
@@ -222,6 +222,11 @@ class _Pickler:
 
     def dump(self, obj):
         """Write a pickled representation of obj to the open file."""
+        # Check whether Pickler was initialized correctly. This is
+        # only needed to mimic the behavior of _pickle.Pickler.dump().
+        if not hasattr(self, "write"):
+            raise PicklingError("Pickler.__init__() was not called by "
+                                "%s.__init__()" % (self.__class__.__name__,))
         if self.proto >= 2:
             self.write(PROTO + bytes([self.proto]))
         self.save(obj)
@@ -789,6 +794,11 @@ class _Unpickler:
 
         Return the reconstituted object hierarchy specified in the file.
         """
+        # Check whether Unpickler was initialized correctly. This is
+        # only needed to mimic the behavior of _pickle.Unpickler.dump().
+        if not hasattr(self, "read"):
+            raise UnpicklingError("Unpickler.__init__() was not called by "
+                                  "%s.__init__()" % (self.__class__.__name__,))
         self.mark = object() # any new unique object
         self.stack = []
         self.append = self.stack.append