From: Victor Stinner <victor.stinner@gmail.com>
Date: Tue, 2 May 2017 14:26:04 +0000 (+0200)
Subject: bpo-30132: distutils BuildExtTestCase use temp_cwd (#1387) (#1388)
X-Git-Tag: v3.5.4rc1~180
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3ceeb84b5a90e327ef55190105e82c926b0b8aab;p=python

bpo-30132: distutils BuildExtTestCase use temp_cwd (#1387) (#1388)

BuildExtTestCase of test_distutils now uses support.temp_cwd() in
setUp() to remove files created in the current working in all
BuildExtTestCase unit tests, not only test_build_ext().

Fix the following warning:

Warning -- files was modified by test_distutils
  Before: []
  After:  ['vc140.pdb']
(cherry picked from commit 30768958490c658fba0fe24f1cabbdad44be22ff)
---

diff --git a/Lib/distutils/tests/test_build_ext.py b/Lib/distutils/tests/test_build_ext.py
index f3df564e37..ce13227126 100644
--- a/Lib/distutils/tests/test_build_ext.py
+++ b/Lib/distutils/tests/test_build_ext.py
@@ -37,6 +37,13 @@ class BuildExtTestCase(TempdirManager,
         from distutils.command import build_ext
         build_ext.USER_BASE = site.USER_BASE
 
+        # bpo-30132: On Windows, a .pdb file may be created in the current
+        # working directory. Create a temporary working directory to cleanup
+        # everything at the end of the test.
+        self.temp_cwd = support.temp_cwd()
+        self.temp_cwd.__enter__()
+        self.addCleanup(self.temp_cwd.__exit__, None, None, None)
+
     def build_ext(self, *args, **kwargs):
         return build_ext(*args, **kwargs)