From: Nico Weber Date: Wed, 1 May 2019 23:32:38 +0000 (+0000) Subject: Revert r359717, "Make check-clang depend on the clang-check binary always" X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3ce957556e97c0989d46385626cdb5b2b17c5801;p=llvm Revert r359717, "Make check-clang depend on the clang-check binary always" The Tooling tests do have a lit.local.cfg with if not config.root.clang_staticanalyzer: config.unsupported = True so what's wrong isn't the missing dep, but that lit prints a warning for the binary missing. This will need a different kind of fix. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359739 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/utils/gn/secondary/clang/test/BUILD.gn b/utils/gn/secondary/clang/test/BUILD.gn index b7fd034fde1..b5c5ec058b9 100644 --- a/utils/gn/secondary/clang/test/BUILD.gn +++ b/utils/gn/secondary/clang/test/BUILD.gn @@ -108,7 +108,6 @@ group("test") { ":lit_unit_site_cfg", "//clang/lib/Headers", "//clang/tools/c-index-test", - "//clang/tools/clang-check", "//clang/tools/clang-diff", "//clang/tools/clang-format", "//clang/tools/clang-import-test", @@ -148,6 +147,7 @@ group("test") { } if (clang_enable_static_analyzer) { deps += [ + "//clang/tools/clang-check", "//clang/tools/clang-extdef-mapping", ] }