From: Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp>
Date: Thu, 4 Nov 2010 12:09:08 +0000 (+0000)
Subject: Issue #5391: mmap.read_byte() should return unsigned value [0, 255]
X-Git-Tag: v3.2a4~154
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3cdd5cb959672ce24dcf8132f3e9bbe27f908dc7;p=python

Issue #5391: mmap.read_byte() should return unsigned value [0, 255]
instead of signed value [-127, 128].
---

diff --git a/Lib/test/test_mmap.py b/Lib/test/test_mmap.py
index 54a43f93df..f78fed95a0 100644
--- a/Lib/test/test_mmap.py
+++ b/Lib/test/test_mmap.py
@@ -534,6 +534,15 @@ class MmapTests(unittest.TestCase):
         m.seek(8)
         self.assertRaises(ValueError, m.write, b"bar")
 
+    def test_non_ascii_byte(self):
+        for b in (129, 200, 255): # > 128
+            m = mmap.mmap(-1, 1)
+            m.write_byte(b)
+            self.assertEquals(m[0], b)
+            m.seek(0)
+            self.assertEquals(m.read_byte(), b)
+            m.close()
+
     if os.name == 'nt':
         def test_tagname(self):
             data1 = b"0123456789"
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 680f1f1102..13d7f5580a 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -204,7 +204,7 @@ mmap_read_byte_method(mmap_object *self,
     if (self->pos < self->size) {
         char value = self->data[self->pos];
         self->pos += 1;
-        return Py_BuildValue("b", value);
+        return Py_BuildValue("B", (unsigned char)value);
     } else {
         PyErr_SetString(PyExc_ValueError, "read byte out of range");
         return NULL;