From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 29 May 2005 17:10:52 +0000 (+0000)
Subject: expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1
X-Git-Tag: REL7_4_9~40
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3c6bba3072a40befa12b57ba610bdb5d6a11c607;p=postgresql

expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1
to columns of an RTE that was a function returning RECORD with a column
definition list.  Apparently no one has tried to use non-default typmod
with a function returning RECORD before.
---

diff --git a/src/backend/parser/parse_relation.c b/src/backend/parser/parse_relation.c
index e12367641d..180ba98512 100644
--- a/src/backend/parser/parse_relation.c
+++ b/src/backend/parser/parse_relation.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.90.2.1 2004/04/18 18:13:31 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.90.2.2 2005/05/29 17:10:52 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1410,7 +1410,7 @@ expandRTE(ParseState *pstate, RangeTblEntry *rte,
 							varnode = makeVar(rtindex,
 											  attnum,
 											  atttypid,
-											  -1,
+											  colDef->typename->typmod,
 											  sublevels_up);
 
 							*colvars = lappend(*colvars, varnode);
@@ -1659,7 +1659,7 @@ get_rte_attribute_type(RangeTblEntry *rte, AttrNumber attnum,
 					ColumnDef  *colDef = nth(attnum - 1, coldeflist);
 
 					*vartype = typenameTypeId(colDef->typename);
-					*vartypmod = -1;
+					*vartypmod = colDef->typename->typmod;
 				}
 				else
 					ereport(ERROR,