From: Ivan Maidanski <ivmai@mail.ru>
Date: Thu, 13 Oct 2016 08:16:23 +0000 (+0300)
Subject: Eliminate 'unnecessary comparison of static strings' cppcheck warning
X-Git-Tag: v8.0.0~1114
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3c0df798ff952ba5c2915788b7671c399f52d270;p=gc

Eliminate 'unnecessary comparison of static strings' cppcheck warning

* tools/if_mach.c (main): Replace strcmp(x, "")!=0 with strlen(x)>0.
---

diff --git a/tools/if_mach.c b/tools/if_mach.c
index 94053a66..f99d1649 100644
--- a/tools/if_mach.c
+++ b/tools/if_mach.c
@@ -9,7 +9,7 @@ int main(int argc, char **argv)
 {
     if (argc < 4) goto Usage;
     if (strcmp(MACH_TYPE, argv[1]) != 0) return(0);
-    if (strcmp(OS_TYPE, "") != 0 && strcmp(argv[2], "") != 0
+    if (strlen(OS_TYPE) > 0 && strlen(argv[2]) > 0
         && strcmp(OS_TYPE, argv[2]) != 0) return(0);
     fprintf(stderr, "^^^^Starting command^^^^\n");
     fflush(stdout);