From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Thu, 21 Dec 2017 17:42:32 +0000 (-0800) Subject: bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter shutdown (GH... X-Git-Tag: v3.6.5rc1~185 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3bc68cff5b821e83ee5df8b8cd13f4f54151b406;p=python bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter shutdown (GH-4956) (#4962) (cherry picked from commit 4a02543cf97e8cbf9293741379f977b85531e4c2) --- diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py index 5ea6c20c67..dde1d3588f 100644 --- a/Lib/asyncio/unix_events.py +++ b/Lib/asyncio/unix_events.py @@ -61,8 +61,14 @@ class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop): def close(self): super().close() - for sig in list(self._signal_handlers): - self.remove_signal_handler(sig) + if not sys.is_finalizing(): + for sig in list(self._signal_handlers): + self.remove_signal_handler(sig) + else: + warinigs.warn(f"Closing the loop {self!r} on interpreter shutdown " + f"stage, signal unsubsription is disabled", + ResourceWarning, + source=self) def _process_self_data(self, data): for signum in data: diff --git a/Misc/NEWS.d/next/Library/2017-12-21-11-08-42.bpo-26133.mt81QV.rst b/Misc/NEWS.d/next/Library/2017-12-21-11-08-42.bpo-26133.mt81QV.rst new file mode 100644 index 0000000000..0653d1960e --- /dev/null +++ b/Misc/NEWS.d/next/Library/2017-12-21-11-08-42.bpo-26133.mt81QV.rst @@ -0,0 +1 @@ +Don't unsubscribe signals in asyncio UNIX event loop on interpreter shutdown.