From: Petri Lehtinen Date: Sun, 6 Nov 2011 18:58:50 +0000 (+0200) Subject: Revert "Accept None as start and stop parameters for list.index() and tuple.index()" X-Git-Tag: v2.7.3rc1~319 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3b9d92aefef17ee528e4bfa0f7e87dc61e4a0da6;p=python Revert "Accept None as start and stop parameters for list.index() and tuple.index()" Issue #13340. --- diff --git a/Lib/test/list_tests.py b/Lib/test/list_tests.py index 9528052e31..b8d6d6bda6 100644 --- a/Lib/test/list_tests.py +++ b/Lib/test/list_tests.py @@ -365,13 +365,6 @@ class CommonTest(seq_tests.CommonTest): self.assertEqual(u.index(0, 3), 3) self.assertEqual(u.index(0, 3, 4), 3) self.assertRaises(ValueError, u.index, 2, 0, -10) - self.assertEqual(u.index(1, None), 4) - self.assertEqual(u.index(1, None, None), 4) - self.assertEqual(u.index(1, 0, None), 4) - self.assertEqual(u.index(1, None, 6), 4) - self.assertRaises(ValueError, u.index, -1, 3) - self.assertRaises(ValueError, u.index, -1, 3, None) - self.assertRaises(ValueError, u.index, 1, None, 4) self.assertRaises(TypeError, u.index) diff --git a/Lib/test/seq_tests.py b/Lib/test/seq_tests.py index 0c8cf903a8..f5e4e0ef55 100644 --- a/Lib/test/seq_tests.py +++ b/Lib/test/seq_tests.py @@ -363,13 +363,6 @@ class CommonTest(unittest.TestCase): self.assertEqual(u.index(0, 3), 3) self.assertEqual(u.index(0, 3, 4), 3) self.assertRaises(ValueError, u.index, 2, 0, -10) - self.assertEqual(u.index(1, None), 4) - self.assertEqual(u.index(1, None, None), 4) - self.assertEqual(u.index(1, 0, None), 4) - self.assertEqual(u.index(1, None, 6), 4) - self.assertRaises(ValueError, u.index, -1, 3) - self.assertRaises(ValueError, u.index, -1, 3, None) - self.assertRaises(ValueError, u.index, 1, None, 4) self.assertRaises(TypeError, u.index) diff --git a/Misc/NEWS b/Misc/NEWS index 9911360973..43e2763f6c 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -11,9 +11,6 @@ Core and Builtins - Remove Py3k warning for callable. -- Issue #13340: Accept None as start and stop parameters for - list.index() and tuple.index(). - - Issue #10519: Avoid unnecessary recursive function calls in setobject.c. diff --git a/Objects/listobject.c b/Objects/listobject.c index 10d9c009c1..f753643bd3 100644 --- a/Objects/listobject.c +++ b/Objects/listobject.c @@ -2277,20 +2277,12 @@ listindex(PyListObject *self, PyObject *args) { Py_ssize_t i, start=0, stop=Py_SIZE(self); PyObject *v, *format_tuple, *err_string; - PyObject *start_obj = NULL, *stop_obj = NULL; static PyObject *err_format = NULL; - if (!PyArg_ParseTuple(args, "O|OO:index", &v, &start_obj, &stop_obj)) + if (!PyArg_ParseTuple(args, "O|O&O&:index", &v, + _PyEval_SliceIndex, &start, + _PyEval_SliceIndex, &stop)) return NULL; - - if (start_obj != Py_None) - if (!_PyEval_SliceIndex(start_obj, &start)) - return NULL; - - if (stop_obj != Py_None) - if (!_PyEval_SliceIndex(stop_obj, &stop)) - return NULL; - if (start < 0) { start += Py_SIZE(self); if (start < 0) diff --git a/Objects/tupleobject.c b/Objects/tupleobject.c index 1f2ab552ae..3249cccdb7 100644 --- a/Objects/tupleobject.c +++ b/Objects/tupleobject.c @@ -510,19 +510,12 @@ static PyObject * tupleindex(PyTupleObject *self, PyObject *args) { Py_ssize_t i, start=0, stop=Py_SIZE(self); - PyObject *v, *start_obj = NULL, *stop_obj = NULL; + PyObject *v; - if (!PyArg_ParseTuple(args, "O|OO:index", &v, &start_obj, &stop_obj)) + if (!PyArg_ParseTuple(args, "O|O&O&:index", &v, + _PyEval_SliceIndex, &start, + _PyEval_SliceIndex, &stop)) return NULL; - - if (start_obj != Py_None) - if (!_PyEval_SliceIndex(start_obj, &start)) - return NULL; - - if (stop_obj != Py_None) - if (!_PyEval_SliceIndex(stop_obj, &stop)) - return NULL; - if (start < 0) { start += Py_SIZE(self); if (start < 0)