From: Anders Carlsson <andersca@mac.com>
Date: Sun, 11 Oct 2009 23:55:52 +0000 (+0000)
Subject: If the base type of a member call is a record type we don't need to emit a virtual... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=3b89f3fa61b65b73f58808c037826c8333830313;p=clang

If the base type of a member call is a record type we don't need to emit a virtual call.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@83816 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CGCXX.cpp b/lib/CodeGen/CGCXX.cpp
index ceb6e4927f..af49942738 100644
--- a/lib/CodeGen/CGCXX.cpp
+++ b/lib/CodeGen/CGCXX.cpp
@@ -230,10 +230,13 @@ RValue CodeGenFunction::EmitCXXMemberCallExpr(const CXXMemberCallExpr *CE) {
   // C++ [class.virtual]p12:
   //   Explicit qualification with the scope operator (5.1) suppresses the
   //   virtual call mechanism.
+  //
+  // We also don't emit a virtual call if the base expression has a record type
+  // because then we know what the type is.
   llvm::Value *Callee;
-  if (MD->isVirtual() && !ME->hasQualifier())
-    // FIXME: push getCanonicalDecl as a conversion using the static type system (CanCXXMethodDecl).
-    Callee = BuildVirtualCall(MD->getCanonicalDecl(), This, Ty);
+  if (MD->isVirtual() && !ME->hasQualifier() && 
+      !ME->getBase()->getType()->isRecordType())
+    Callee = BuildVirtualCall(MD, This, Ty);
   else if (const CXXDestructorDecl *Destructor
              = dyn_cast<CXXDestructorDecl>(MD))
     Callee = CGM.GetAddrOfFunction(GlobalDecl(Destructor, Dtor_Complete), Ty);
@@ -795,8 +798,6 @@ CodeGenFunction::GetVirtualCXXBaseClassOffset(llvm::Value *This,
 llvm::Value *
 CodeGenFunction::BuildVirtualCall(const CXXMethodDecl *MD, llvm::Value *&This,
                                   const llvm::Type *Ty) {
-  // FIXME: If we know the dynamic type, we don't have to do a virtual dispatch.
-
   int64_t Index = CGM.getVtableInfo().getMethodVtableIndex(MD);
   
   Ty = llvm::PointerType::get(Ty, 0);
diff --git a/test/CodeGenCXX/virtual-function-calls.cpp b/test/CodeGenCXX/virtual-function-calls.cpp
index e3a19a34a1..34ab1df689 100644
--- a/test/CodeGenCXX/virtual-function-calls.cpp
+++ b/test/CodeGenCXX/virtual-function-calls.cpp
@@ -1,4 +1,4 @@
-// RUN: clang-cc -emit-llvm-only %s
+// RUN: clang-cc %s -emit-llvm -o - | FileCheck %s
 
 // PR5021
 struct A {
@@ -8,3 +8,10 @@ struct A {
 void f(A *a) {
   a->f('c');
 }
+
+void f(A a) {
+  // This should not be a virtual function call.
+  
+  // CHECK: call void @_ZN1A1fEc
+  a.f('c');
+}
\ No newline at end of file